<p dir="ltr">Great, thanks for following up on that! Teresa</p>
<br><div class="gmail_quote"><div dir="ltr">On Thu, Nov 10, 2016, 1:54 PM Aaron Ballman <<a href="mailto:aaron.ballman@gmail.com">aaron.ballman@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, Oct 28, 2016 at 11:46 AM, Aaron Ballman <<a href="mailto:aaron.ballman@gmail.com" class="gmail_msg" target="_blank">aaron.ballman@gmail.com</a>> wrote:<br class="gmail_msg">
> On Fri, Oct 28, 2016 at 11:43 AM, Teresa Johnson <<a href="mailto:tejohnson@google.com" class="gmail_msg" target="_blank">tejohnson@google.com</a>> wrote:<br class="gmail_msg">
>><br class="gmail_msg">
>> Aaron, will you be able to revert this change when the bot is upgraded? Tanya - any ETA? Or one of you can let me know and I will revert it.<br class="gmail_msg">
><br class="gmail_msg">
> I'm happy to revert once the bot is upgraded.<br class="gmail_msg">
<br class="gmail_msg">
To follow up on this -- Tanya fixed the documentation bot today so<br class="gmail_msg">
that it's no longer on GCC 4.7. If the bot works properly during its<br class="gmail_msg">
daily build cycle (which it is expected to), I will update the cmake<br class="gmail_msg">
files to bring back the GCC 4.8 version checking tomorrow morning.<br class="gmail_msg">
<br class="gmail_msg">
Thanks!<br class="gmail_msg">
<br class="gmail_msg">
~Aaron<br class="gmail_msg">
<br class="gmail_msg">
><br class="gmail_msg">
> ~Aaron<br class="gmail_msg">
><br class="gmail_msg">
>><br class="gmail_msg">
>> Thanks,<br class="gmail_msg">
>> Teresa<br class="gmail_msg">
>><br class="gmail_msg">
>> On Fri, Oct 28, 2016 at 8:39 AM, Teresa Johnson <<a href="mailto:tejohnson@google.com" class="gmail_msg" target="_blank">tejohnson@google.com</a>> wrote:<br class="gmail_msg">
>>><br class="gmail_msg">
>>> This revision was automatically updated to reflect the committed changes.<br class="gmail_msg">
>>> Closed by commit rL285406: [cmake] Temporarily revert enforcement of minimum GCC version increase (authored by tejohnson).<br class="gmail_msg">
>>><br class="gmail_msg">
>>> Changed prior to commit:<br class="gmail_msg">
>>> <a href="https://reviews.llvm.org/D26078?vs=76198&id=76200#toc" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D26078?vs=76198&id=76200#toc</a><br class="gmail_msg">
>>><br class="gmail_msg">
>>> Repository:<br class="gmail_msg">
>>> rL LLVM<br class="gmail_msg">
>>><br class="gmail_msg">
>>> <a href="https://reviews.llvm.org/D26078" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D26078</a><br class="gmail_msg">
>>><br class="gmail_msg">
>>> Files:<br class="gmail_msg">
>>> llvm/trunk/cmake/modules/CheckCompilerVersion.cmake<br class="gmail_msg">
>>><br class="gmail_msg">
>>><br class="gmail_msg">
>>> Index: llvm/trunk/cmake/modules/CheckCompilerVersion.cmake<br class="gmail_msg">
>>> ===================================================================<br class="gmail_msg">
>>> --- llvm/trunk/cmake/modules/CheckCompilerVersion.cmake<br class="gmail_msg">
>>> +++ llvm/trunk/cmake/modules/CheckCompilerVersion.cmake<br class="gmail_msg">
>>> @@ -8,8 +8,9 @@<br class="gmail_msg">
>>><br class="gmail_msg">
>>> if(NOT LLVM_FORCE_USE_OLD_TOOLCHAIN)<br class="gmail_msg">
>>> if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")<br class="gmail_msg">
>>> - if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.8)<br class="gmail_msg">
>>> - message(FATAL_ERROR "Host GCC version must be at least 4.8!")<br class="gmail_msg">
>>> + # FIXME: Change this to 4.8 once documentation builder bot is upgraded<br class="gmail_msg">
>>> + if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.7)<br class="gmail_msg">
>>> + message(FATAL_ERROR "Host GCC version must be at least 4.7!")<br class="gmail_msg">
>>> endif()<br class="gmail_msg">
>>> elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")<br class="gmail_msg">
>>> if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3.1)<br class="gmail_msg">
>>> @@ -35,7 +36,8 @@<br class="gmail_msg">
>>> int main() { return (float)x; }"<br class="gmail_msg">
>>> LLVM_NO_OLD_LIBSTDCXX)<br class="gmail_msg">
>>> if(NOT LLVM_NO_OLD_LIBSTDCXX)<br class="gmail_msg">
>>> - message(FATAL_ERROR "Host Clang must be able to find libstdc++4.8 or newer!")<br class="gmail_msg">
>>> + # FIXME: Change this to 4.8 once documentation builder bot is upgraded<br class="gmail_msg">
>>> + message(FATAL_ERROR "Host Clang must be able to find libstdc++4.7 or newer!")<br class="gmail_msg">
>>> endif()<br class="gmail_msg">
>>> set(CMAKE_REQUIRED_FLAGS ${OLD_CMAKE_REQUIRED_FLAGS})<br class="gmail_msg">
>>> set(CMAKE_REQUIRED_LIBRARIES ${OLD_CMAKE_REQUIRED_LIBRARIES})<br class="gmail_msg">
>>><br class="gmail_msg">
>>><br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>> --<br class="gmail_msg">
>> Teresa Johnson | Software Engineer | <a href="mailto:tejohnson@google.com" class="gmail_msg" target="_blank">tejohnson@google.com</a> | <a href="tel:(408)%20460-2413" value="+14084602413" class="gmail_msg" target="_blank">408-460-2413</a><br class="gmail_msg">
</blockquote></div>