<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 11/8/2016 7:13 AM, Teresa Johnson
wrote:<br>
</div>
<blockquote
cite="mid:CAAe5K+VACZYW9Bqa+B5zW3ePtT4F5Hh4rxMjToyZQpgh0e3JpQ@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Nov 8, 2016 at 3:30 AM,
Rafael Espíndola via llvm-commits <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:llvm-commits@lists.llvm.org"
target="_blank">llvm-commits@lists.llvm.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">emitError takes a twine
and I don't think it is safe to have a twine<br>
variable. Could this be just:<br>
<br>
emitError(Twine("could not write object file: ") +
Filename);<br>
</blockquote>
<div><br>
</div>
<div>Right, this isn't safe. Per Twine.h:</div>
<div>
<div> /// A Twine is not intended for use directly and
should not be stored, its</div>
<div> /// implementation relies on the ability to store
pointers to temporary stack</div>
<div> /// objects which may be deallocated at the end of
a statement. Twines should</div>
<div> /// only be used accepted as const references in
arguments, when an API wishes</div>
<div> /// to accept possibly-concatenated strings.</div>
</div>
<div><br>
</div>
<div>Please change to Rafael's suggestion.</div>
<br>
</div>
</div>
</div>
</blockquote>
<br>
r286275.<br>
<br>
-Eli<br>
<pre class="moz-signature" cols="72">--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project</pre>
</body>
</html>