<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">This is C code, not C++, and the issue is that some system header on Darwin used to define nullptr for C code, but it doesn't do that anymore. I think we already have -std=c++11 for all C++ test cases (at least in TSan). This test case is actually C code, even though the filename has ".cc". We should change this to be C++ (i.e. change %clang_tsan to %clangxx_tsan), let me do that in a subsequent commit.</div><div class=""><br class=""></div><div class="">Kuba</div><br class=""><div><blockquote type="cite" class=""><div class="">On 8 Nov 2016, at 12:14, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">These are built by the just-built clang, right? So is it just that on some platforms clang's default language doesn't have nullptr? Perhaps we should add an explicit -std=c++11 to the test case?</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Mon, Nov 7, 2016 at 2:35 PM Kuba Brecka via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kuba.brecka<br class="gmail_msg">
Date: Mon Nov 7 16:26:13 2016<br class="gmail_msg">
New Revision: 286166<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=286166&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=286166&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[tsan] Change nullptr to NULL in <a href="http://realloc-zero.cc" class="">realloc-zero.cc</a> test. Some environments don't have nullptr.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
compiler-rt/trunk/test/tsan/Darwin/<a href="http://realloc-zero.cc" class="">realloc-zero.cc</a><br class="gmail_msg">
<br class="gmail_msg">
Modified: compiler-rt/trunk/test/tsan/Darwin/<a href="http://realloc-zero.cc" class="">realloc-zero.cc</a><br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/realloc-zero.cc?rev=286166&r1=286165&r2=286166&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/realloc-zero.cc?rev=286166&r1=286165&r2=286166&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- compiler-rt/trunk/test/tsan/Darwin/<a href="http://realloc-zero.cc" class="">realloc-zero.cc</a> (original)<br class="gmail_msg">
+++ compiler-rt/trunk/test/tsan/Darwin/<a href="http://realloc-zero.cc" class="">realloc-zero.cc</a> Mon Nov 7 16:26:13 2016<br class="gmail_msg">
@@ -9,7 +9,7 @@<br class="gmail_msg">
#include <sys/mman.h><br class="gmail_msg">
<br class="gmail_msg">
int main() {<br class="gmail_msg">
- void *p = realloc(nullptr, 0);<br class="gmail_msg">
+ void *p = realloc(NULL, 0);<br class="gmail_msg">
if (!p) {<br class="gmail_msg">
abort();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>