<div dir="ltr">It's never instantiated because we don't have a unittest that exercises this form of increment (see my comment in the commit message).</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 8, 2016 at 12:20 PM David Blaikie via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Surprised we weren't getting a -Wreturn-type warning for this?</div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Fri, Nov 4, 2016 at 12:26 AM Chandler Carruth via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chandlerc<br class="gmail_msg">
Date: Fri Nov  4 02:16:33 2016<br class="gmail_msg">
New Revision: 285990<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=285990&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=285990&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Add a missing return to the move assignment operator for<br class="gmail_msg">
SequenceNumberManager.<br class="gmail_msg">
<br class="gmail_msg">
Sadly, we don't have any unittests for this class because it is<br class="gmail_msg">
a private class. Since it seems to have a nice isolated and testable<br class="gmail_msg">
interface, it'd be great to extract it to a detail namespace and write<br class="gmail_msg">
unit tests for it as then we could catch issues. I'll probably pester<br class="gmail_msg">
Lang about that or some alternative refactoring.<br class="gmail_msg">
<br class="gmail_msg">
This was noticed by PVS-Studio.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCUtils.h<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCUtils.h<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCUtils.h?rev=285990&r1=285989&r2=285990&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCUtils.h?rev=285990&r1=285989&r2=285990&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCUtils.h (original)<br class="gmail_msg">
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCUtils.h Fri Nov  4 02:16:33 2016<br class="gmail_msg">
@@ -700,6 +700,7 @@ private:<br class="gmail_msg">
     SequenceNumberManager &operator=(SequenceNumberManager &&Other) {<br class="gmail_msg">
       NextSequenceNumber = std::move(Other.NextSequenceNumber);<br class="gmail_msg">
       FreeSequenceNumbers = std::move(Other.FreeSequenceNumbers);<br class="gmail_msg">
+      return *this;<br class="gmail_msg">
     }<br class="gmail_msg">
<br class="gmail_msg">
     void reset() {<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>