<div dir="ltr">Thanks!<div>Teresa</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 8, 2016 at 11:43 AM, Eli Friedman via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: efriedma<br>
Date: Tue Nov  8 13:43:56 2016<br>
New Revision: 286275<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=286275&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=286275&view=rev</a><br>
Log:<br>
Don't store Twine in a local variable.<br>
<br>
Fixes post-commit review comment from r286177.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/lib/LTO/<wbr>LTOCodeGenerator.cpp<br>
<br>
Modified: llvm/trunk/lib/LTO/<wbr>LTOCodeGenerator.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LTOCodeGenerator.cpp?rev=286275&r1=286274&r2=286275&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/LTO/<wbr>LTOCodeGenerator.cpp?rev=<wbr>286275&r1=286274&r2=286275&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/LTO/<wbr>LTOCodeGenerator.cpp (original)<br>
+++ llvm/trunk/lib/LTO/<wbr>LTOCodeGenerator.cpp Tue Nov  8 13:43:56 2016<br>
@@ -257,8 +257,7 @@ bool LTOCodeGenerator::<wbr>compileOptimizedT<br>
   bool genResult = compileOptimized(&objFile.os()<wbr>);<br>
   objFile.os().close();<br>
   if (objFile.os().has_error()) {<br>
-    Twine ErrMsg = "could not write object file: " + Filename.str();<br>
-    emitError(ErrMsg.str());<br>
+    emitError((Twine("could not write object file: ") + Filename).str());<br>
     objFile.os().clear_error();<br>
     sys::fs::remove(Twine(<wbr>Filename));<br>
     return false;<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div>