<div dir="ltr">I'm so sorry that I didn't notice it. Submitted r285489 to fix the issue.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 28, 2016 at 6:32 PM, Yung, Douglas <span dir="ltr"><<a href="mailto:douglas.yung@sony.com" target="_blank">douglas.yung@sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Rui,<br>
<br>
I don't know if you are aware of this or not, but the PS4 Windows bot still seems to be broken, and it looks like it was from the file you tried to fix here. It appears another similar change might be needed on line 13 to fully qualify BAlloc?<br>
<br>
Here is the error message from the PS4 Windows build bot when it tried to build this change (<a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/324" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/llvm-clang-lld-x86_<wbr>64-scei-ps4-windows10pro-fast/<wbr>builds/324</a>):<br>
<br>
C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>tools\lld\ELF\Memory.cpp(13): error C2065: 'BAlloc': undeclared identifier<br>
<span class="HOEnZb"><font color="#888888"><br>
Douglas Yung<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
> -----Original Message-----<br>
> From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org">llvm-commits-bounces@<wbr>lists.llvm.org</a>] On<br>
> Behalf Of Rui Ueyama via llvm-commits<br>
> Sent: Friday, October 28, 2016 14:10<br>
> To: <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> Subject: [lld] r285453 - Attempt to fix a buildbot.<br>
><br>
> Author: ruiu<br>
> Date: Fri Oct 28 16:09:56 2016<br>
> New Revision: 285453<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=285453&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=285453&view=rev</a><br>
> Log:<br>
> Attempt to fix a buildbot.<br>
><br>
> Modified:<br>
>     lld/trunk/ELF/Memory.cpp<br>
><br>
> Modified: lld/trunk/ELF/Memory.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/lld/trunk/ELF/Memory.<wbr>cpp?rev=285453&r1=285452&r2=<wbr>285453&view=di<br>
> ff<br>
> ==============================<wbr>==============================<wbr>===========<br>
> =======<br>
> --- lld/trunk/ELF/Memory.cpp (original)<br>
> +++ lld/trunk/ELF/Memory.cpp Fri Oct 28 16:09:56 2016<br>
> @@ -12,4 +12,4 @@<br>
>  llvm::BumpPtrAllocator lld::elf::BAlloc;  llvm::StringSaver<br>
> lld::elf::Saver{BAlloc};<br>
><br>
> -void lld::elf::freeArena() { BAlloc.Reset(); }<br>
> +void lld::elf::freeArena() { lld::elf::BAlloc.Reset(); }<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>