<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 26, 2016 at 5:39 PM, Peter Collingbourne <span dir="ltr"><<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Drive by comment: maybe you want something like<div><br></div><div>if (sizeof(T) == 4)</div><div>  TORC4.Insert(ArgXor, Arg1, Arg2);</div><div>else if sizeof(T) == 8)</div><div>  TORC8.Insert(ArgXor, Arg1, Arg2);</div><div><br></div><div>in TracePC::HandleCmp?</div></div></blockquote><div><br></div><div>Hmmm. This will cause Arg1 to be passed to functions with wrong parameters under if(0). </div><div>But seems to work with both g++ and clang.. testing.. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Wed, Oct 26, 2016 at 5:22 PM, Kostya Serebryany via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kcc<br>
Date: Wed Oct 26 19:22:39 2016<br>
New Revision: 285259<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=285259&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=285259&view=rev</a><br>
Log:<br>
[libFuzzer] speculatively trying to fix the Mac build<br>
<br>
Modified:<br>
    llvm/trunk/lib/Fuzzer/FuzzerTr<wbr>acePC.h<br>
<br>
Modified: llvm/trunk/lib/Fuzzer/FuzzerTr<wbr>acePC.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/FuzzerTracePC.h?rev=285259&r1=285258&r2=285259&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/lib/Fuzzer/Fu<wbr>zzerTracePC.h?rev=285259&r1=28<wbr>5258&r2=285259&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Fuzzer/FuzzerTr<wbr>acePC.h (original)<br>
+++ llvm/trunk/lib/Fuzzer/FuzzerTr<wbr>acePC.h Wed Oct 26 19:22:39 2016<br>
@@ -111,7 +111,7 @@ private:<br>
     // Do nothing, too small to be interesting.<br>
   }<br>
   void TORCInsert(size_t Idx, uint16_t Arg1, uint16_t Arg2) {<br>
-    // Do nothing, these don't usually hapen.<br>
+    // Do nothing, these don't usually happen.<br>
   }<br>
   void TORCInsert(size_t Idx, uint32_t Arg1, uint32_t Arg2) {<br>
     TORC4.Insert(Idx, Arg1, Arg2);<br>
@@ -119,6 +119,9 @@ private:<br>
   void TORCInsert(size_t Idx, uint64_t Arg1, uint64_t Arg2) {<br>
     TORC8.Insert(Idx, Arg1, Arg2);<br>
   }<br>
+  void TORCInsert(size_t Idx, uintptr_t Arg1, uintptr_t Arg2) {<br>
+    TORC8.Insert(Idx, Arg1, Arg2);<br>
+  }<br>
<br>
   static const size_t kNumPCs = 1 << 24;<br>
   uintptr_t PCs[kNumPCs];<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_3421325036524139457gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</font></span></div>
</blockquote></div><br></div></div>