<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Victor, we usually try very hard to keep all the upgrade tests working. When we discover that a testcase is buggy (e.g., because the Verifier was improved since it was created) the right course of action is to check out the version of llvm that was used to create the testcase, fix the error in the .ll file, assemble it with the old llvm and commit the fixed bitcode.<div class=""><br class=""></div><div class="">-- adrian<br class=""><div><blockquote type="cite" class=""><div class="">On Oct 24, 2016, at 9:22 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">What/why/how/when was it broken? Do we not need to support the bitcode it was testing?<br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Oct 19, 2016 at 5:35 PM Victor Leschuk via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vleschuk<br class="gmail_msg">
Date: Wed Oct 19 19:26:36 2016<br class="gmail_msg">
New Revision: 284682<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=284682&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=284682&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
DebugInfo: remove broken bitcode upgrade test<br class="gmail_msg">
<br class="gmail_msg">
Removed:<br class="gmail_msg">
llvm/trunk/test/Bitcode/dilocalvariable-3.9.ll<br class="gmail_msg">
llvm/trunk/test/Bitcode/dilocalvariable-3.9.ll.bc<br class="gmail_msg">
<br class="gmail_msg">
Removed: llvm/trunk/test/Bitcode/dilocalvariable-3.9.ll<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bitcode/dilocalvariable-3.9.ll?rev=284681&view=auto" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bitcode/dilocalvariable-3.9.ll?rev=284681&view=auto</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/test/Bitcode/dilocalvariable-3.9.ll (original)<br class="gmail_msg">
+++ llvm/trunk/test/Bitcode/dilocalvariable-3.9.ll (removed)<br class="gmail_msg">
@@ -1,43 +0,0 @@<br class="gmail_msg">
-; RUN: llvm-dis -o - %s.bc | FileCheck %s<br class="gmail_msg">
-<br class="gmail_msg">
-; CHECK: !9 = !DILocalVariable(name: "i", scope: !6, file: !1, line: 3, type: !10)<br class="gmail_msg">
-; CHECK: !10 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed)<br class="gmail_msg">
-<br class="gmail_msg">
-source_filename = "test.cpp"<br class="gmail_msg">
-target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"<br class="gmail_msg">
-target triple = "x86_64-unknown-linux-gnu"<br class="gmail_msg">
-<br class="gmail_msg">
-; Function Attrs: nounwind uwtable<br class="gmail_msg">
-define void @_Z1fv() #0 !dbg !6 {<br class="gmail_msg">
-entry:<br class="gmail_msg">
- %i = alloca i32, align 4<br class="gmail_msg">
- call void @llvm.dbg.declare(metadata i32* %i, metadata !10, metadata !12), !dbg !13<br class="gmail_msg">
- store i32 42, i32* %i, align 4, !dbg !13<br class="gmail_msg">
- ret void, !dbg !14<br class="gmail_msg">
-}<br class="gmail_msg">
-<br class="gmail_msg">
-; Function Attrs: nounwind readnone<br class="gmail_msg">
-declare void @llvm.dbg.declare(metadata, metadata, metadata) #1<br class="gmail_msg">
-<br class="gmail_msg">
-attributes #0 = { nounwind uwtable }<br class="gmail_msg">
-attributes #1 = { nounwind readnone }<br class="gmail_msg">
-<br class="gmail_msg">
-!<a href="http://llvm.dbg.cu/" rel="noreferrer" class="gmail_msg" target="_blank">llvm.dbg.cu</a> = !{!0}<br class="gmail_msg">
-!llvm.module.flags = !{!3, !4}<br class="gmail_msg">
-!llvm.ident = !{!5}<br class="gmail_msg">
-<br class="gmail_msg">
-!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1, producer: "clang version 3.9.1 (<a href="http://llvm.org/git/clang.git" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/git/clang.git</a> c3709e72d22432f53f8e2f14354def31a96734fe)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !2)<br class="gmail_msg">
-!1 = !DIFile(filename: "test.cpp", directory: "/tmp")<br class="gmail_msg">
-!2 = !{}<br class="gmail_msg">
-!3 = !{i32 2, !"Dwarf Version", i32 4}<br class="gmail_msg">
-!4 = !{i32 2, !"Debug Info Version", i32 3}<br class="gmail_msg">
-!5 = !{!"clang version 3.9.1 (<a href="http://llvm.org/git/clang.git" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/git/clang.git</a> c3709e72d22432f53f8e2f14354def31a96734fe)"}<br class="gmail_msg">
-!6 = distinct !DISubprogram(name: "f", linkageName: "_Z1fv", scope: !7, file: !7, line: 1, type: !8, isLocal: false, isDefinition: true, scopeLine: 2, flags: DIFlagPrototyped, isOptimized: false, unit: !0, variables: !2)<br class="gmail_msg">
-!7 = !DIFile(filename: "test.cpp", directory: "/tmp")<br class="gmail_msg">
-!8 = !DISubroutineType(types: !9)<br class="gmail_msg">
-!9 = !{null}<br class="gmail_msg">
-!10 = !DILocalVariable(name: "i", scope: !6, file: !7, line: 3, type: !11)<br class="gmail_msg">
-!11 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed)<br class="gmail_msg">
-!12 = !DIExpression()<br class="gmail_msg">
-!13 = !DILocation(line: 3, column: 7, scope: !6)<br class="gmail_msg">
-!14 = !DILocation(line: 4, column: 1, scope: !6)<br class="gmail_msg">
<br class="gmail_msg">
Removed: llvm/trunk/test/Bitcode/dilocalvariable-3.9.ll.bc<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bitcode/dilocalvariable-3.9.ll.bc?rev=284681&view=auto" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bitcode/dilocalvariable-3.9.ll.bc?rev=284681&view=auto</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
(empty)<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></div>
</div></blockquote></div><br class=""></div></body></html>