<div dir="ltr">Nope.<div>Go for it!</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 21, 2016 at 1:18 PM, Geoff Berry <span dir="ltr"><<a href="mailto:gberry@codeaurora.org" target="_blank">gberry@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    <p>Would you be opposed to me making this change in a follow-on
      change since I've already done all of my testing on this version?<br>
    </p><div><div class="h5">
    <br>
    <div class="m_-7678405613977588103moz-cite-prefix">On 10/21/2016 4:15 PM, Daniel Berlin
      wrote:<br>
    </div>
    <blockquote type="cite">
      <div dir="ltr">(IE you can use getClobberingAccess always, and not
        worry about it)</div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Fri, Oct 21, 2016 at 1:14 PM, Daniel
          Berlin <span dir="ltr"><<a href="mailto:dberlin@dberlin.org" target="_blank">dberlin@dberlin.org</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div dir="ltr"><span>"<span style="font-size:12.8px">Also, when using MemorySSA to
                  check if two MemoryUses are reading from</span><br style="font-size:12.8px">
                <span style="font-size:12.8px">the same version of the
                  heap, use the defining access instead of calling</span><br style="font-size:12.8px">
                <span style="font-size:12.8px">getClobberingAccess,
                  since the latter can currently result in many more</span><br style="font-size:12.8px">
                <span style="font-size:12.8px">AA calls."<br>
                  <br>
                </span></span>
              <div><span style="font-size:12.8px">This should be fixed
                  as of yesterday.</span></div>
              <div><span style="font-size:12.8px"><br>
                </span></div>
            </div>
            <div class="m_-7678405613977588103HOEnZb">
              <div class="m_-7678405613977588103h5">
                <div class="gmail_extra"><br>
                  <div class="gmail_quote">On Fri, Oct 21, 2016 at 1:12
                    PM, Geoff Berry <span dir="ltr"><<a href="mailto:gberry@codeaurora.org" target="_blank">gberry@codeaurora.org</a>></span>
                    wrote:<br>
                    <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">gberry
                      created this revision.<br>
                      gberry added a reviewer: dberlin.<br>
                      gberry added subscribers: llvm-commits, mcrosier.<br>
                      <br>
                      When using MemorySSA, re-optimize MemoryPhis when
                      removing a store since<br>
                      this may create MemoryPhis with all identical
                      arguments.<br>
                      <br>
                      Also, when using MemorySSA to check if two
                      MemoryUses are reading from<br>
                      the same version of the heap, use the defining
                      access instead of calling<br>
                      getClobberingAccess, since the latter can
                      currently result in many more<br>
                      AA calls.  Once the MemorySSA use optimization
                      tracking changes are<br>
                      done, we can remove this limitation, which should
                      result in more loads<br>
                      being CSE'd.<br>
                      <br>
                      <br>
                      <a href="https://reviews.llvm.org/D25881" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2588<wbr>1</a><br>
                      <br>
                      Files:<br>
                        lib/Transforms/Scalar/EarlyCSE<wbr>.cpp<br>
                        test/Transforms/EarlyCSE/memor<wbr>yssa.ll<br>
                      <br>
                    </blockquote>
                  </div>
                  <br>
                </div>
              </div>
            </div>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
    </div></div><span class="HOEnZb"><font color="#888888"><pre class="m_-7678405613977588103moz-signature" cols="72">-- 
Geoff Berry
Employee of Qualcomm Datacenter Technologies, Inc.
 Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.</pre>
  </font></span></div>

</blockquote></div><br></div>