<div dir="ltr">I didn't noticed since I am too behind of llvmdev.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 20, 2016 at 8:23 AM Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">r284661</div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Wed, Oct 19, 2016 at 3:36 PM, Reid Kleckner <span dir="ltr" class="gmail_msg"><<a href="mailto:rnk@google.com" class="gmail_msg" target="_blank">rnk@google.com</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">I'm going to revert this, MSVC 2013 (_MSC_VER < 1900) is no longer supported as of Oct 15. Please upgrade to MSVC 2015.</div><div class="m_-2218566825392983793HOEnZb gmail_msg"><div class="m_-2218566825392983793h5 gmail_msg"><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Tue, Oct 18, 2016 at 10:43 PM, NAKAMURA Takumi via llvm-commits <span dir="ltr" class="gmail_msg"><<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chapuni<br class="gmail_msg">
Date: Wed Oct 19 00:43:17 2016<br class="gmail_msg">
New Revision: 284570<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=284570&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=284570&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
DenseSet: Appease msc18 to define derived constructors explicitly.<br class="gmail_msg">
<br class="gmail_msg">
msc18 doesn't recognize "using BaseT::BaseT;"<br class="gmail_msg">
<br class="gmail_msg">
  llvm\include\llvm/ADT/DenseSet.h(213) : error C2875: using-declaration causes a multiple declaration of 'BaseT'<br class="gmail_msg">
          llvm\include\llvm/ADT/DenseSet.h(214) : see reference to class template instantiation 'llvm::DenseSet<ValueT,ValueInfoT>' being compiled<br class="gmail_msg">
  llvm\include\llvm/ADT/DenseSet.h(231) : error C2875: using-declaration causes a multiple declaration of 'BaseT'<br class="gmail_msg">
          llvm\include\llvm/ADT/DenseSet.h(232) : see reference to class template instantiation 'llvm::SmallDenseSet<ValueT,InlineBuckets,ValueInfoT>' being compiled<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/include/llvm/ADT/DenseSet.h<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/include/llvm/ADT/DenseSet.h<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseSet.h?rev=284570&r1=284569&r2=284570&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseSet.h?rev=284570&r1=284569&r2=284570&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/include/llvm/ADT/DenseSet.h (original)<br class="gmail_msg">
+++ llvm/trunk/include/llvm/ADT/DenseSet.h Wed Oct 19 00:43:17 2016<br class="gmail_msg">
@@ -210,7 +210,13 @@ class DenseSet : public detail::DenseSet<br class="gmail_msg">
                            ValueInfoT>;<br class="gmail_msg">
<br class="gmail_msg">
 public:<br class="gmail_msg">
+#if defined(_MSC_VER) && _MSC_VER < 1900<br class="gmail_msg">
+  explicit DenseSet(unsigned InitialReserve = 0)<br class="gmail_msg">
+      : DenseSetImpl(InitialReserve) {}<br class="gmail_msg">
+  DenseSet(std::initializer_list<ValueT> Elems) : DenseSetImpl(Elems) {}<br class="gmail_msg">
+#else<br class="gmail_msg">
   using BaseT::BaseT;<br class="gmail_msg">
+#endif<br class="gmail_msg">
 };<br class="gmail_msg">
<br class="gmail_msg">
 /// Implements a dense probed hash-table based set with some number of buckets<br class="gmail_msg">
@@ -228,7 +234,13 @@ class SmallDenseSet<br class="gmail_msg">
       ValueInfoT>;<br class="gmail_msg">
<br class="gmail_msg">
 public:<br class="gmail_msg">
+#if defined(_MSC_VER) && _MSC_VER < 1900<br class="gmail_msg">
+  explicit SmallDenseSet(unsigned InitialReserve = 0)<br class="gmail_msg">
+      : DenseSetImpl(InitialReserve) {}<br class="gmail_msg">
+  SmallDenseSet(std::initializer_list<ValueT> Elems) : DenseSetImpl(Elems) {}<br class="gmail_msg">
+#else<br class="gmail_msg">
   using BaseT::BaseT;<br class="gmail_msg">
+#endif<br class="gmail_msg">
 };<br class="gmail_msg">
<br class="gmail_msg">
 } // end namespace llvm<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div><br class="gmail_msg"></div>
</div></div></blockquote></div><br class="gmail_msg"></div>
</blockquote></div>