<div dir="ltr">Hi Will,<div><br></div><div>If there's a way to produce this relocation with an assembly directive, I would add a regression test along the lines of test/ExecutionEngine/<wbr>RuntimeDyld/X86/ELF-relaxed.s . Otherwise, this looks good to me.</div><div><br></div><div>Cheers,</div><div>Lang.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 13, 2016 at 6:45 AM, Will Dietz via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ping?<div><br></div><div>To help explain/motivate:</div><div><br></div><div>Files with these relocations can be given to RuntimeDyld through an object or archive,</div><div>and without this fix RuntimeDyld hits the "Relocation type not implemented" unreachable/assertion failure.</div><div>(Not sure if any of our JIT's would produce the need for these, but maybe them too)</div><div><br></div><div><br></div><div>Why this is correct:</div><div><br></div><div>Searching the same file you can see how the equivalent relocation is handled on other architectures (R_ARM_NONE, R_MIPS_NONE), which is the same: do nothing :).</div><div><br></div><div>I don't have a useful way to craft a test for this, but if that's a blocker please let me know and I'll see what I can do.</div><div><br></div><div>Thanks! :)</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>~Will</div></font></span></div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 21, 2016 at 9:28 AM Will Dietz <<a href="mailto:wdietz2@illinois.edu" target="_blank">wdietz2@illinois.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_8130691091073926954gmail_msg"><div class="m_8130691091073926954gmail_msg">Patch attached and reproduced below inline:<br class="m_8130691091073926954gmail_msg"></div><div class="m_8130691091073926954gmail_msg">----------------------</div><div class="m_8130691091073926954gmail_msg"><div class="m_8130691091073926954gmail_msg">From 91f56e48e0d267c8647410652be57d<wbr>d7ab69200b Mon Sep 17 00:00:00 2001</div><div class="m_8130691091073926954gmail_msg">From: Will Dietz <<a href="mailto:w@wdtz.org" class="m_8130691091073926954gmail_msg" target="_blank">w@wdtz.org</a>></div><div class="m_8130691091073926954gmail_msg">Date: Wed, 27 Jul 2016 07:20:37 -0500</div><div class="m_8130691091073926954gmail_msg">Subject: [PATCH] RuntimeDyldELF: Don't abort on R_X86_64_NONE, they're no-ops.</div><div class="m_8130691091073926954gmail_msg"><br class="m_8130691091073926954gmail_msg"></div><div class="m_8130691091073926954gmail_msg">---</div><div class="m_8130691091073926954gmail_msg"> lib/ExecutionEngine/<wbr>RuntimeDyld/RuntimeDyldELF.cpp | 2 ++</div><div class="m_8130691091073926954gmail_msg"> 1 files changed, 2 insertions(+), 0 deletions(-)</div><div class="m_8130691091073926954gmail_msg"><br class="m_8130691091073926954gmail_msg"></div><div class="m_8130691091073926954gmail_msg">diff --git a/lib/ExecutionEngine/<wbr>RuntimeDyld/RuntimeDyldELF.cpp b/lib/ExecutionEngine/<wbr>RuntimeDyld/RuntimeDyldELF.cpp</div><div class="m_8130691091073926954gmail_msg">index 9cbdb13..ec8fe3a 100644</div><div class="m_8130691091073926954gmail_msg">--- a/lib/ExecutionEngine/<wbr>RuntimeDyld/RuntimeDyldELF.cpp</div><div class="m_8130691091073926954gmail_msg">+++ b/lib/ExecutionEngine/<wbr>RuntimeDyld/RuntimeDyldELF.cpp</div><div class="m_8130691091073926954gmail_msg">@@ -231,6 +231,8 @@ void RuntimeDyldELF::resolveX86_<wbr>64Relocation(const SectionEntry &Section,</div><div class="m_8130691091073926954gmail_msg"> default:</div><div class="m_8130691091073926954gmail_msg"> llvm_unreachable("Relocation type not implemented yet!");</div><div class="m_8130691091073926954gmail_msg"> break;</div><div class="m_8130691091073926954gmail_msg">+ case ELF::R_X86_64_NONE:</div><div class="m_8130691091073926954gmail_msg">+ break;</div><div class="m_8130691091073926954gmail_msg"> case ELF::R_X86_64_64: {</div><div class="m_8130691091073926954gmail_msg"> support::ulittle64_t::ref(<wbr>Section.getAddressWithOffset(<wbr>Offset)) =</div><div class="m_8130691091073926954gmail_msg"> Value + Addend;</div></div></div><div dir="ltr" class="m_8130691091073926954gmail_msg"><div class="m_8130691091073926954gmail_msg"><div class="m_8130691091073926954gmail_msg">-- </div><div class="m_8130691091073926954gmail_msg">1.7.1</div><div class="m_8130691091073926954gmail_msg"><br class="m_8130691091073926954gmail_msg"></div></div></div></blockquote></div>
</div></div><br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>