<div dir="ltr">Were these copies problematic in any way? If it's just a POD type, you might as well leave it copyable, etc?</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Oct 12, 2016 at 3:53 PM Vedant Kumar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vedantk<br class="gmail_msg">
Date: Wed Oct 12 17:44:50 2016<br class="gmail_msg">
New Revision: 284069<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=284069&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=284069&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[unittests] Delete even more copy constructors (NFC)<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp?rev=284069&r1=284068&r2=284069&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp?rev=284069&r1=284068&r2=284069&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp Wed Oct 12 17:44:50 2016<br class="gmail_msg">
@@ -106,6 +106,16 @@ struct InputFunctionCoverageData {<br class="gmail_msg">
<br class="gmail_msg">
   InputFunctionCoverageData(std::string Name, uint64_t Hash)<br class="gmail_msg">
       : Name(std::move(Name)), Hash(Hash) {}<br class="gmail_msg">
+<br class="gmail_msg">
+  InputFunctionCoverageData(InputFunctionCoverageData &&IFCD)<br class="gmail_msg">
+      : ReverseVirtualFileMapping(std::move(IFCD.ReverseVirtualFileMapping)),<br class="gmail_msg">
+        Name(std::move(IFCD.Name)), Hash(IFCD.Hash),<br class="gmail_msg">
+        Regions(std::move(IFCD.Regions)) {}<br class="gmail_msg">
+<br class="gmail_msg">
+  InputFunctionCoverageData(const InputFunctionCoverageData &) = delete;<br class="gmail_msg">
+  InputFunctionCoverageData &<br class="gmail_msg">
+  operator=(const InputFunctionCoverageData &) = delete;<br class="gmail_msg">
+  InputFunctionCoverageData &operator=(InputFunctionCoverageData &&) = delete;<br class="gmail_msg">
 };<br class="gmail_msg">
<br class="gmail_msg">
 struct CoverageMappingTest : ::testing::Test {<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>