<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Oct 17, 2016 at 9:58 AM Justin Lebar <<a href="mailto:jlebar@google.com">jlebar@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Please send complaints to whoever is responsible for making phab work<br class="gmail_msg">
properly.  It should have picked up these changes, and didn't, for<br class="gmail_msg">
some reason.  :)  (I don't know if it's fixed now.)<br class="gmail_msg">
<br class="gmail_msg">
I don't use svn, so pulling out svn revisions is nontrivial, sorry.<br class="gmail_msg"></blockquote><div><br>The mailing list and subversion are the systems of record we use on the project - bugs in Phab or otherwise. It'd be really helpful if you could include that information.<br><br>It's provided in the commit description including on the link you provided:<br><br>r283764<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg">
On Mon, Oct 17, 2016 at 9:56 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="gmail_msg" target="_blank">dblaikie@gmail.com</a>> wrote:<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> On Mon, Oct 10, 2016 at 3:42 PM Justin Lebar via llvm-commits<br class="gmail_msg">
> <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
>><br class="gmail_msg">
>> jlebar closed this revision.<br class="gmail_msg">
>> jlebar added a comment.<br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>> <a href="https://github.com/llvm-mirror/llvm/commit/f086ef8c8bc8eec1f850d867d2ce1a43da5569e6" rel="noreferrer" class="gmail_msg" target="_blank">https://github.com/llvm-mirror/llvm/commit/f086ef8c8bc8eec1f850d867d2ce1a43da5569e6</a><br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> By this ^ you were indicating that this change was committed?<br class="gmail_msg">
><br class="gmail_msg">
> It'd be helpful to mention the SVN revision when doing so.<br class="gmail_msg">
><br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>> <a href="https://reviews.llvm.org/D25404" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D25404</a><br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>> _______________________________________________<br class="gmail_msg">
>> llvm-commits mailing list<br class="gmail_msg">
>> <a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></div>