<html><head></head><body>This also changes some bits of the implementation, like comparing the hash in isequal. Could you make this do just the move and rename?<br>
<br>
<br>
LGTM if the implementation is not changed in this patch.<br><br><div class="gmail_quote">On October 15, 2016 6:07:22 PM EDT, Justin Lebar via llvm-commits <llvm-commits@lists.llvm.org> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">jlebar created this revision.<br />jlebar added a reviewer: timshen.<br />jlebar added a subscriber: llvm-commits.<br /><br />Reclaiming the name 'CachedHashString' will let us add a type with that<br />name that owns its value.<br /><br /><br /><a href="https://reviews.llvm.org/D25644">https://reviews.llvm.org/D25644</a><br /><br />Files:<br /> lld/ELF/InputSection.cpp<br /> lld/ELF/OutputSections.cpp<br /> lld/ELF/OutputSections.h<br /> llvm/include/llvm/ADT/CachedHashString.h<br /> llvm/include/llvm/MC/StringTableBuilder.h<br /> llvm/lib/MC/StringTableBuilder.cpp<br /> llvm/unittests/MC/StringTableBuilderTest.cpp<br /><br /></pre><p style="margin-top: 2.5em; margin-bottom: 1em; border-bottom: 1px solid #000"></p><pre class="k9mail"><hr /><br />llvm-commits mailing list<br />llvm-commits@lists.llvm.org<br /><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br
/></pre></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>