<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 14, 2016, at 10:13 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Oct 14, 2016 at 9:59 AM Adrian Prantl <<a href="mailto:aprantl@apple.com" class="">aprantl@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="gmail_msg"><br class="">> On Oct 14, 2016, at 9:48 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="gmail_msg" target="_blank">dblaikie@gmail.com</a>> wrote:<br class="gmail_msg"><br class="">><br class="gmail_msg"><br class="">> Could someone point me to where the discussion for adding this type came out of? I didn't spot it at a cursory glance of the previous/existing threads.<br class="gmail_msg"><br class="">><br class="gmail_msg"><br class=""><br class="gmail_msg"><br class="">This came out of the review thread in:<br class="gmail_msg"><br class=""><br class="gmail_msg"><br class="">D25073: [DebugInfo]: preparation to implement DW_AT_alignment<br class="gmail_msg"><br class=""><a href="https://reviews.llvm.org/D25073" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D25073</a><br class="gmail_msg"><br class=""><br class="gmail_msg"><br class="">where I argued that we should not be using a full uint64_t for the alignment fields in the DI.* metadata nodes. I don't think the concrete solution of introducing a new alignment type has been discussed here before.<br class="gmail_msg"></blockquote><div class=""><br class=""></div><div class="">Any particular benefits of introducing a new type? We don't I think have any wrapper types for otherwise singular numeric values, do we? (except maybe DIFlags?)</div></div></div></div></blockquote><div><br class=""></div><div>I don't have a strong opinion about adding a new type. If we also had a separate type for sizes, we could potentially make the interface more typesafe to avoid accidentally confusing size and alignment, but that's about it.</div><div><br class=""></div><div>-- adrian</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class=""><br class="gmail_msg"><br class="">-- adrian<br class="gmail_msg"><br class=""></blockquote></div></div>
</div></blockquote></div><br class=""></body></html>