<p dir="ltr">Thanks!</p>
<br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 14, 2016, 2:41 PM Mehdi Amini <<a href="mailto:mehdi.amini@apple.com">mehdi.amini@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">r284283<br class="gmail_msg">
<br class="gmail_msg">
—<br class="gmail_msg">
Mehdi<br class="gmail_msg">
<br class="gmail_msg">
> On Oct 14, 2016, at 2:30 PM, Teresa Johnson <<a href="mailto:tejohnson@google.com" class="gmail_msg" target="_blank">tejohnson@google.com</a>> wrote:<br class="gmail_msg">
><br class="gmail_msg">
> tejohnson added a comment.<br class="gmail_msg">
><br class="gmail_msg">
> In <a href="https://reviews.llvm.org/D25585#570756" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D25585#570756</a>, @thakis wrote:<br class="gmail_msg">
><br class="gmail_msg">
>> The new test fails if I cmake with -DLLVM_ENABLE_THREADS=OFF. I guess this just needs a `#if LLVM_ENABLE_THREADS`?<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> Yes that's right. With LLVM_ENABLE_THREADS=OFF hardware_concurrency will return 1, so the test will fail. I took the day off today, if you want to submit a fix then LGTM. I will do so tonight if you don't have a chance before then.<br class="gmail_msg">
><br class="gmail_msg">
> Thanks<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> Repository:<br class="gmail_msg">
>  rL LLVM<br class="gmail_msg">
><br class="gmail_msg">
> <a href="https://reviews.llvm.org/D25585" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D25585</a><br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>