<div dir="ltr"><div><div><span style="font-family:monospace,monospace">I am going to set it it builder definition, also I might change the implementation in favor of cmake option LLVM_ENABLE_LTO={THIN,FULL}, which I am in the middle of checking.<br><br></span></div><span style="font-family:monospace,monospace"></span><span style="font-family:monospace,monospace"></span></div><span style="font-family:monospace,monospace"></span><span style="font-family:monospace,monospace"></span><br><span style="font-family:monospace,monospace"></span><div><div><span style="font-family:monospace,monospace"> {'name' : "clang-with-thin-lto-ubuntu",<br>         'slavenames' : ["ps4-buildslave1a"],<br>         'builddir' : "clang-with-thin-lto-ubuntu",<br>         'factory': ClangLTOBuilder.getClangWithLTOBuildFactory(lto='thin'),<br>         'category'   : 'lld'},<br><br><br></span></div><div><span style="font-family:monospace,monospace">Thanks<br><br></span></div><div><span style="font-family:monospace,monospace">Galina<br></span></div><div><span style="font-family:monospace,monospace"><br><br></span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 13, 2016 at 1:13 PM, Davide Italiano <span dir="ltr"><<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, Oct 13, 2016 at 12:32 PM, Galina Kistanova via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: gkistanova<br>
> Date: Thu Oct 13 14:32:23 2016<br>
> New Revision: 284153<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=284153&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=284153&view=rev</a><br>
> Log:<br>
> Added support for ThinLTO.<br>
><br>
<br>
</span>Thanks. I may miss something, but where are you actually setting `-flto=thin` ?<br>
<div class="HOEnZb"><div class="h5"><br>
> Modified:<br>
>     zorg/trunk/zorg/buildbot/<wbr>builders/ClangLTOBuilder.py<br>
><br>
> Modified: zorg/trunk/zorg/buildbot/<wbr>builders/ClangLTOBuilder.py<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/ClangLTOBuilder.py?rev=284153&r1=284152&r2=284153&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/zorg/trunk/zorg/<wbr>buildbot/builders/<wbr>ClangLTOBuilder.py?rev=284153&<wbr>r1=284152&r2=284153&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- zorg/trunk/zorg/buildbot/<wbr>builders/ClangLTOBuilder.py (original)<br>
> +++ zorg/trunk/zorg/buildbot/<wbr>builders/ClangLTOBuilder.py Thu Oct 13 14:32:23 2016<br>
> @@ -233,6 +233,7 @@ def getClangWithLTOBuildFactory(<br>
>             jobs  = None,<br>
>             extra_configure_args = None,<br>
>             compare_last_2_stages = True,<br>
> +           lto = None, # The string gets passed to -flto flag as is. Like -flto=thin.<br>
>             env = None):<br>
><br>
>      # Set defaults<br>
> @@ -305,11 +306,16 @@ def getClangWithLTOBuildFactory(<br>
>      # Build all the remaining stages with exactly the same configuration.<br>
><br>
>      # Set proper compile and link flags.<br>
> +    if lto:<br>
> +        lto = '-flto=%s' % lto<br>
> +    else:<br>
> +        lto = '-flto'<br>
> +<br>
>      CmakeCommand.appendFlags(<wbr>extra_configure_args, [<br>
> -        ('-DCMAKE_CXX_FLAGS=',           ['-flto']),<br>
> -        ('-DCMAKE_EXE_LINKER_FLAGS=',    ['-flto', '-fuse-ld=lld']),<br>
> -        ('-DCMAKE_MODULE_LINKER_FLAGS=<wbr>', ['-flto', '-fuse-ld=lld']),<br>
> -        ('-DCMAKE_SHARED_LINKER_FLAGS=<wbr>', ['-flto', '-fuse-ld=lld']),<br>
> +        ('-DCMAKE_CXX_FLAGS=',           [lto]),<br>
> +        ('-DCMAKE_EXE_LINKER_FLAGS=',    [lto, '-fuse-ld=lld']),<br>
> +        ('-DCMAKE_MODULE_LINKER_FLAGS=<wbr>', [lto, '-fuse-ld=lld']),<br>
> +        ('-DCMAKE_SHARED_LINKER_FLAGS=<wbr>', [lto, '-fuse-ld=lld']),<br>
>          ])<br>
><br>
>      # The rest are test stages, which depend on the staged compiler we are ultimately after.<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</font></span></blockquote></div><br></div></div>