<div dir="ltr">What I meant was that we should just expose a string or something here, rather than the Comdat pointer.<div><br></div><div>Peter</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 28, 2016 at 5:31 PM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Wed Sep 28 19:31:45 2016<br>
New Revision: 282655<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=282655&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=282655&view=rev</a><br>
Log:<br>
[LTO] Add a FIXME, we shouldn't expose getComdat().<br>
<br>
Thanks to Peter for the suggestion.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/LTO/<wbr>LTO.h<br>
<br>
Modified: llvm/trunk/include/llvm/LTO/<wbr>LTO.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/LTO/LTO.h?rev=282655&r1=282654&r2=282655&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/LTO/LTO.h?rev=282655&r1=<wbr>282654&r2=282655&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/LTO/<wbr>LTO.h (original)<br>
+++ llvm/trunk/include/llvm/LTO/<wbr>LTO.h Wed Sep 28 19:31:45 2016<br>
@@ -175,6 +175,8 @@ public:<br>
       // FIXME: Expose a thread-local flag for module asm symbols.<br>
       return GV && GV->isThreadLocal();<br>
     }<br>
+<br>
+    //FIXME: We shouldn't expose this information.<br>
     Expected<const Comdat *> getComdat() const {<br>
       if (!GV)<br>
         return nullptr;<br>
@@ -191,6 +193,7 @@ public:<br>
         return GO->getComdat();<br>
       return nullptr;<br>
     }<br>
+<br>
     uint64_t getCommonSize() const {<br>
       assert(Flags & object::BasicSymbolRef::SF_<wbr>Common);<br>
       if (!GV)<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>