<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Brian, this seems to break some of our bots with something along the lines of:</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><pre class="console-output" style="box-sizing: border-box; white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51);">ImportError: 'module' object has no attribute ‘main'</pre><pre class="console-output" style="box-sizing: border-box; white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51);"><br></pre></div> These bots are installing lit into a virtualenv, then using it.<br><p class="airmail_on">Many of our test bots are broken because of this. Can you investigate or revert asap? Thanks!</p><p class="airmail_on"><br></p><p class="airmail_on">On October 9, 2016 at 6:31:16 PM, Brian Gesiak via llvm-commits (<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>Author: modocache<br>Date: Sun Oct 9 20:22:06 2016<br>New Revision: 283710<br><br>URL: http://llvm.org/viewvc/llvm-project?rev=283710&view=rev<br>Log:<br>[lit] Remove (or allow specific) unused imports<br><br>Summary:<br>Using Python linter flake8 on the utils/lit reveals several linter<br>warnings designated "F401: Unused import". Fix or silence these<br>warnings.<br><br>Some of these unused imports are legitimate, while some are part of lit's API.<br>For example, users of lit expect to be able to access `lit.formats.ShTest` in<br>their `lit.cfg`, despite the module hierarchy for that symbol actually being<br>`lit.formats.shtest.ShTest`. To silence linter errors for these lines,<br>include a "noqa" directive.<br><br>Reviewers: echristo, delcypher, beanz, ddunbar<br><br>Subscribers: mehdi_amini, llvm-commits<br><br>Differential Revision: https://reviews.llvm.org/D25407<br><br>Modified:<br> llvm/trunk/utils/lit/lit.py<br> llvm/trunk/utils/lit/lit/LitConfig.py<br> llvm/trunk/utils/lit/lit/__init__.py<br> llvm/trunk/utils/lit/lit/formats/__init__.py<br><br>Modified: llvm/trunk/utils/lit/lit.py<br>URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit.py?rev=283710&r1=283709&r2=283710&view=diff<br>==============================================================================<br>--- llvm/trunk/utils/lit/lit.py (original)<br>+++ llvm/trunk/utils/lit/lit.py Sun Oct 9 20:22:06 2016<br>@@ -1,5 +1,6 @@<br> #!/usr/bin/env python<br> <br>+from lit.main import main<br>+<br> if __name__=='__main__':<br>- import lit<br>- lit.main()<br>+ main()<br><br>Modified: llvm/trunk/utils/lit/lit/LitConfig.py<br>URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/LitConfig.py?rev=283710&r1=283709&r2=283710&view=diff<br>==============================================================================<br>--- llvm/trunk/utils/lit/lit/LitConfig.py (original)<br>+++ llvm/trunk/utils/lit/lit/LitConfig.py Sun Oct 9 20:22:06 2016<br>@@ -83,7 +83,7 @@ class LitConfig(object):<br> # a timeout per test. Check it's available.<br> # See lit.util.killProcessAndChildren()<br> try:<br>- import psutil<br>+ import psutil # noqa: F401<br> except ImportError:<br> self.fatal("Setting a timeout per test requires the"<br> " Python psutil module but it could not be"<br><br>Modified: llvm/trunk/utils/lit/lit/__init__.py<br>URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/__init__.py?rev=283710&r1=283709&r2=283710&view=diff<br>==============================================================================<br>--- llvm/trunk/utils/lit/lit/__init__.py (original)<br>+++ llvm/trunk/utils/lit/lit/__init__.py Sun Oct 9 20:22:06 2016<br>@@ -1,8 +1,5 @@<br> """'lit' Testing Tool"""<br> <br>-from __future__ import absolute_import<br>-from .main import main<br>-<br> __author__ = 'Daniel Dunbar'<br> __email__ = 'daniel@minormatter.com'<br> __versioninfo__ = (0, 6, 0)<br><br>Modified: llvm/trunk/utils/lit/lit/formats/__init__.py<br>URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/formats/__init__.py?rev=283710&r1=283709&r2=283710&view=diff<br>==============================================================================<br>--- llvm/trunk/utils/lit/lit/formats/__init__.py (original)<br>+++ llvm/trunk/utils/lit/lit/formats/__init__.py Sun Oct 9 20:22:06 2016<br>@@ -1,4 +1,8 @@<br>-from __future__ import absolute_import<br>-from lit.formats.base import TestFormat, FileBasedTest, OneCommandPerFileTest<br>-from lit.formats.googletest import GoogleTest<br>-from lit.formats.shtest import ShTest<br>+from lit.formats.base import ( # noqa: F401<br>+ TestFormat,<br>+ FileBasedTest,<br>+ OneCommandPerFileTest<br>+)<br>+<br>+from lit.formats.googletest import GoogleTest # noqa: F401<br>+from lit.formats.shtest import ShTest # noqa: F401<br><br><br>_______________________________________________<br>llvm-commits mailing list<br>llvm-commits@lists.llvm.org<br>http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br></div></div></span></blockquote></body></html>