<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 4, 2016 at 12:11 AM Chandler Carruth via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">chandlerc accepted this revision.<br class="gmail_msg"><br>chandlerc added a reviewer: chandlerc.<br class="gmail_msg"><br>chandlerc added a comment.<br class="gmail_msg"><br><br class="gmail_msg"><br>LGTM as well. I like the FooLower pattern. While somewhat verbose and repetitive, it seems much more clear and obvious to the reader. It is also much simpler.<br class="gmail_msg"></blockquote><div><br></div><div>Personally I think I'd have voted for flags passed to the Switch function, somewhat as Rui was suggesting:<br><br>  x = StringSwitch(y, CaseInsensitive).Case(...).Case(...);<br><br>I wouldn't really want to have that explosion of variations (mixing case sensitive and insensitive, etc) until we've got a particular use case, it seems pretty niche.<br><br>- Dave</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br class="gmail_msg"><br><br class="gmail_msg"><br><a href="https://reviews.llvm.org/D24686" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D24686</a><br class="gmail_msg"><br><br class="gmail_msg"><br><br class="gmail_msg"><br><br class="gmail_msg"><br>_______________________________________________<br class="gmail_msg"><br>llvm-commits mailing list<br class="gmail_msg"><br><a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg"><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg"><br></blockquote></div></div>