In particular, if this is for local development, keeping this patch local also helps enforce this since any accidental use of the triple in public code will break quite obviously.<div><br></div><div><div dir="auto"><br></div><div dir="auto"><br><div class="gmail_quote"><div dir="ltr">On Sun, Oct 2, 2016, 7:32 PM Daniel Berlin <<a href="mailto:dberlin@dberlin.org">dberlin@dberlin.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">So why not keep this patch local as well?<br class="gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Sat, Oct 1, 2016, 9:47 AM Saleem Abdulrasool via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">compnerd added a comment.<br class="gmail_msg">
<br class="gmail_msg">
The patch implicitly has tests: the unit tests generically walks over the enumeration, so it is covered by existing tests.<br class="gmail_msg">
<br class="gmail_msg">
This would allow Facebook to play around with changes that they need for local development, which may not necessarily be generic enough or generally correct for merging into the mainline.<br class="gmail_msg">
<br class="gmail_msg">
I don't think that there is any real maintenance cost associated with adding the additional vendor triple, especially if it doesnt require altering the normal code paths.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D25136" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D25136</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></blockquote></div></div></div>