<table><tr><td style="">phosek created this revision.<br />phosek added a reviewer: beanz.<br />phosek added subscribers: llvm-commits, phosek.<br />phosek set the repository for this revision to rL LLVM.<br />Herald added a subscriber: mgorny.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://reviews.llvm.org/D25067" rel="noreferrer">View Revision</a></tr></table><br /><div><p>When LLVM_INSTALL_TOOLCHAIN_ONLY is used and LLVM_TOOLCHAIN_TOOLS contains a tool which is a symlink, it would be ignored. This already worked before but got broken in r282510.</p></div><br /><div><strong><strong>Repository:</strong></strong><div><div>rL LLVM</div></div></div><br /><div><a href="https://reviews.llvm.org/D25067" rel="noreferrer">https://reviews.llvm.org/D25067</a></div><br /><div><strong><strong>Files:</strong></strong><div><div>cmake/modules/AddLLVM.cmake</div></div></div><br /><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><span style="color: #4b4d51; font-weight: bold;">cmake/modules/AddLLVM.cmake</span></div><div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #304a96">endif</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span style="color: #304a96">if</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">NO</span>T</span> <span style="color: #766510">LLVM_<span class="bright">INSTALL_</span>TOOLCHAIN_<span class="bright">ONLY</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">AND</span></span> <span style="color: #766510">LLVM_<span class="bright">BUILD</span>_TOOL<span class="bright">S</span></span><span class="bright"> </span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #304a96">if</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">name</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">IN_LIS</span>T</span> <span style="color: #766510">LLVM_TOOLCHAIN_<span class="bright">TOOLS</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">OR</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">NOT</span></span> <span style="color: #766510">LLVM_<span class="bright">INSTALL</span>_TOOL<span class="bright">CHAIN_ONLY</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">      <span style="color: #304a96">if</span> <span class="p">(</span><span style="color: #766510">LLVM_BUILD_TOOLS</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #304a96">llvm_install_symlink</span><span class="p">(</span><span style="color: #aa2211">${</span><span style="color: #001294">name</span><span style="color: #aa2211">}</span> <span style="color: #aa2211">${</span><span style="color: #001294">dest</span><span style="color: #aa2211">}</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">      <span style="color: #304a96">endif</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #304a96">endif</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">  <span style="color: #304a96">endif</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">endfunction</span><span class="p">()</span>
</div></div></div></div></div><br />