<table><tr><td style="">beanz added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://reviews.llvm.org/D25067" rel="noreferrer">View Revision</a></tr></table><br /><div><p>Looking at this, I messed up that logic worse than this fixes. I completely broke <tt style="background: #ebebeb; font-size: 13px;">LLVM_INSTALL_TOOLCHAIN_ONLY=Off</tt> for symlinks.</p>

<p>I think something like this would cover your case and fix <tt style="background: #ebebeb; font-size: 13px;">LLVM_INSTALL_TOOLCHAIN_ONLY</tt>:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="diff" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span></span><span style="color: #000080">diff --git a/cmake/modules/AddLLVM.cmake b/cmake/modules/AddLLVM.cmake</span>
<span style="color: #000080">index 51ae62d..00f2e80 100644</span>
<span style="color: #a00000">--- a/cmake/modules/AddLLVM.cmake</span>
<span style="color: #00a000">+++ b/cmake/modules/AddLLVM.cmake</span>
<span style="color: #800080">@@ -1264,11 +1264,11 @@ function(add_llvm_tool_symlink name dest)</span>
     set_target_properties(${target_name} PROPERTIES FOLDER Tools)
 
     # Make sure both the link and target are toolchain tools
<span style="color: #a00000">-    if (NOT ${name} IN_LIST LLVM_TOOLCHAIN_TOOLS OR NOT ${dest} IN_LIST LLVM_TOOLCHAIN_TOOLS)</span>
<span style="color: #a00000">-      return()</span>
<span style="color: #00a000">+    if (${name} IN_LIST LLVM_TOOLCHAIN_TOOLS OR ${dest} IN_LIST LLVM_TOOLCHAIN_TOOLS)</span>
<span style="color: #00a000">+      set(TOOL_IS_TOOLCHAIN On)</span>
     endif()
 
<span style="color: #a00000">-    if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY AND LLVM_BUILD_TOOLS )</span>
<span style="color: #00a000">+    if ((TOOL_IS_TOOLCHAIN OR NOT LLVM_INSTALL_TOOLCHAIN_ONLY) AND LLVM_BUILD_TOOLS)</span>
       llvm_install_symlink(${name} ${dest})
     endif()
   endif()</pre></div>

<p>Thoughts?</p></div><br /><div><strong><strong>Repository:</strong></strong><div><div>rL LLVM</div></div></div><br /><div><a href="https://reviews.llvm.org/D25067" rel="noreferrer">https://reviews.llvm.org/D25067</a></div><br />