<div dir="ltr">Oh, it looks like it was already taken care of in r282862.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 30, 2016 at 7:48 AM, Adrian McCarthy <span dir="ltr"><<a href="mailto:amccarth@google.com" target="_blank">amccarth@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I can fix up those Windows files this morning.</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 30, 2016 at 3:04 AM, Stefan van Kessel via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">StefanVK added a comment.<br>
<br>
This broke the build on windows/msvc (see <a href="http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/766" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/clang-x86-windows-msvc2015<wbr>/builds/766</a>)<br>
<br>
Host/windows/Windows.cpp<br>
Plugins/ObjectFile/PECOFF/Wind<wbr>owsMiniDump.cpp<br>
Plugins/Process/Windows/MiniDu<wbr>mp/ProcessWinMiniDump.cpp<br>
<br>
use:<br>
llvm::UTF16;<br>
llvm::UTF8;<br>
llvm::UTF32;<br>
llvm::ConversionFlags;<br>
llvm::conversionOK;<br>
llvm::strictConversion;<br>
<br>
But have no using declaration or other means of finding the moved typedefs<br>
<span class="m_-6792863344953292476im m_-6792863344953292476HOEnZb"><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D24996" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2499<wbr>6</a><br>
<br>
<br>
<br>
</span><div class="m_-6792863344953292476HOEnZb"><div class="m_-6792863344953292476h5">______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>