<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 29, 2016, at 1:42 PM, Adrian McCarthy <<a href="mailto:amccarth@google.com" class="">amccarth@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Sorry about the trouble. Fixed in r282761. </div></div></blockquote><div><br class=""></div>thanks for the quick turnaround!</div><div><br class=""></div><div>-- adrian<br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Sep 29, 2016 at 1:16 PM, Adrian McCarthy <span dir="ltr" class=""><<a href="mailto:amccarth@google.com" target="_blank" class="">amccarth@google.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Sure, I'll post a fix in a few minutes. Running tests now...</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Sep 29, 2016 at 12:58 PM, Adrian Prantl <span dir="ltr" class=""><<a href="mailto:aprantl@apple.com" target="_blank" class="">aprantl@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br class="">
> On Sep 20, 2016, at 10:20 AM, Adrian McCarthy via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
> +<br class="">
> + // Some Microsoft tools, like Binscope, expect a backend version number of at<br class="">
> + // least 8.something, so we'll coerce the LLVM version into a form that<br class="">
> + // guarantees it'll be big enough without really lying about the version.<br class="">
> + Version BackVer = {<br class="">
> + 1000 * LLVM_VERSION_MAJOR +<br class="">
> + 10 * LLVM_VERSION_MINOR +<br class="">
> + LLVM_VERSION_PATCH,<br class="">
> + 0, 0, 0 };<br class="">
> + OS.AddComment("Backend version");<br class="">
> + for (int N = 0; N < 4; ++N)<br class="">
> + OS.EmitIntValue(BackVer.Part[N<wbr class="">], 2);<br class="">
> +<br class="">
<br class="">
</span>This happens to break some of our internal buildbots. Some of them are configured to set LLVM_VERSION_MAJOR to 9999 which doesn't fit into the allocated 2 bytes when multiplied with 1000 and asserts in OS.EmitIntValue. Since we don't impose any limits on LLVM_VERSION_MAJOR it would be good to handle this gracefully here. Could you please take a look? I'm fine with clamping the number to 0xffff or something like that.<br class="">
<br class="">
thanks!<br class="">
<span class="m_6179848541875785456HOEnZb"><font color="#888888" class="">-- adrian<br class="">
</font></span></blockquote></div><br class=""></div>
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>