<div dir="ltr">Good catch. Changed the prefix and it worked. Pushing upstream</div><div class="gmail_extra"><br><div class="gmail_quote">2016-09-29 8:37 GMT-07:00 Teresa Johnson <span dir="ltr"><<a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Downloaded latest patch from email since Phab down. LGTM with fix for test issue that Mehdi pointed out. I don't have a strong feeling on lambda, and Mehdi seems to be leaving that up to your preference too.<div><br></div><div>Thanks,</div><div>Teresa</div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Wed, Sep 28, 2016 at 9:45 PM, Mehdi AMINI <span dir="ltr"><<a href="mailto:mehdi.amini@apple.com" target="_blank">mehdi.amini@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>mehdi_amini added inline comments.<br>
<br>
================<br>
</span>Comment at: test/Transforms/FunctionImport<wbr>/hotness_based_import.ll:32<br>
@@ -30,1 +31,3 @@<br>
<span><br>
+; RUN: opt -function-import -summary-file %t3.thinlto.bc %t.bc -import-instr-limit=1 -import-hot-multiplier=1.0 -import-cold-multiplier=1.0 --S | FileCheck %s --check-prefix=CHECK --check-prefix=HOT-ONE<br>
+; HOT-COLD-ONE-DAG: define available_externally void @hot1()<br>
</span>----------------<br>
If this test passes, I think there's something wrong (the prefix is the same as the previous one...)<br>
<br>
<br>
<a href="https://reviews.llvm.org/D24940" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2494<wbr>0</a><br>
<br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> <a href="tel:408-460-2413" value="+14084602413" target="_blank">408-460-2413</a></td></tr></tbody></table></span></div>
</font></span></div>
</blockquote></div><br></div>