<div dir="ltr">I would slightly prefer not to expose it, but if it is left exposed we should add a FIXME. We're already exposing Comdat via Symbol::getComdat() and we should likely have a FIXME there as well.<div><br></div><div>Peter</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-09-28 14:57 GMT-07:00 Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I think the only oddity I still see in the patch is exposing<br>
getComdatSymbolTable. I think it is OK to have it for the first patch<br>
and remove it in a follow up. Rui, Peter, what do you think?<br>
<br>
Cheers,<br>
Rafael<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
2016-09-28 13:47 GMT-07:00 Davide Italiano <<a href="mailto:dccitaliano@gmail.com">dccitaliano@gmail.com</a>>:<br>
> davide updated this revision to Diff 72890.<br>
> davide added a comment.<br>
><br>
> run clang-format manually and it seems fine on my side.<br>
><br>
><br>
> <a href="https://reviews.llvm.org/D24492" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D24492</a><br>
><br>
> Files:<br>
>   lld/ELF/Error.h<br>
>   lld/ELF/InputFiles.cpp<br>
>   lld/ELF/InputFiles.h<br>
>   lld/ELF/LTO.cpp<br>
>   lld/ELF/LTO.h<br>
>   lld/ELF/SymbolTable.cpp<br>
>   lld/ELF/SymbolTable.h<br>
>   lld/ELF/Symbols.h<br>
>   lld/test/ELF/lto/archive-3.ll<br>
>   lld/test/ELF/lto/asmundef.ll<br>
>   lld/test/ELF/lto/available-<wbr>externally.ll<br>
>   lld/test/ELF/lto/common2.ll<br>
>   lld/test/ELF/lto/common3.ll<br>
>   lld/test/ELF/lto/discard-<wbr>value-names.ll<br>
>   lld/test/ELF/lto/drop-debug-<wbr>info.ll<br>
>   lld/test/ELF/lto/drop-linkage.<wbr>ll<br>
>   lld/test/ELF/lto/internalize-<wbr>basic.ll<br>
>   lld/test/ELF/lto/internalize-<wbr>exportdyn.ll<br>
>   lld/test/ELF/lto/internalize-<wbr>llvmused.ll<br>
>   lld/test/ELF/lto/internalize-<wbr>undef.ll<br>
>   lld/test/ELF/lto/internalize-<wbr>version-script.ll<br>
>   lld/test/ELF/lto/irmover-<wbr>error.ll<br>
>   lld/test/ELF/lto/linkonce-odr.<wbr>ll<br>
>   lld/test/ELF/lto/linkonce.ll<br>
>   lld/test/ELF/lto/ltopasses-<wbr>basic.ll<br>
>   lld/test/ELF/lto/ltopasses-<wbr>custom.ll<br>
>   lld/test/ELF/lto/save-temps.ll<br>
>   lld/test/ELF/lto/type-merge.ll<br>
>   lld/test/ELF/lto/type-merge2.<wbr>ll<br>
>   lld/test/ELF/lto/unnamed-addr-<wbr>comdat.ll<br>
>   lld/test/ELF/lto/unnamed-addr-<wbr>drop.ll<br>
>   lld/test/ELF/lto/unnamed-addr-<wbr>lib.ll<br>
>   lld/test/ELF/lto/unnamed-addr.<wbr>ll<br>
>   lld/test/ELF/lto/version-<wbr>script.ll<br>
>   llvm/include/llvm/LTO/LTO.h<br>
><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>