<html><head></head><body>I wonder if we should change the lexer to always spilt the =.<br>
<br>
In any case, LGTM.<br><br><div class="gmail_quote">On September 23, 2016 3:44:39 AM EDT, George Rimar <grimar@accesssoftek.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">grimar updated the summary for this revision.<br />grimar updated this revision to Diff 72237.<br />grimar added a comment.<br /><br />- Addressed review comments.<br /><br /><br /><a href="https://reviews.llvm.org/D24831">https://reviews.llvm.org/D24831</a><br /><br />Files:<br /> ELF/LinkerScript.cpp<br /> test/ELF/linkerscript/sections-padding.s<br /><br />Index: test/ELF/linkerscript/sections-padding.s<br /><hr /><br />--- test/ELF/linkerscript/sections-padding.s<br />+++ test/ELF/linkerscript/sections-padding.s<br />@@ -31,6 +31,11 @@<br /> # RUN: | FileCheck --check-prefix=ERR2 %s<br /> # ERR2: invalid filler expression: 0x99XX<br /> <br />+## Check case with space between '=' and expression:<br />+# RUN: echo "SECTIONS { .mysec : { *(.mysec*) } = 0x1122 }" > %t.script<br />+# RUN: ld.lld -o %t.out --script %t.script %t<br />+# RUN: llvm-objdump -s %t.out | FileCheck -check-prefix=YES %s<br />+<br /> .section .mysec.1,"a"<br /> .align 16<br
/> .byte 0x66<br />Index: ELF/LinkerScript.cpp<br /><hr /><br />--- ELF/LinkerScript.cpp<br />+++ ELF/LinkerScript.cpp<br />@@ -1217,8 +1217,12 @@<br /> setError("unknown command " + Tok);<br /> }<br /> Cmd->Phdrs = readOutputSectionPhdrs();<br />- if (peek().startswith("="))<br />+<br />+ if (skip("="))<br />+ Cmd->Filler = readOutputSectionFiller(next());<br />+ else if (peek().startswith("="))<br /> Cmd->Filler = readOutputSectionFiller(next().drop_front());<br />+<br /> return Cmd;<br /> }<br /> <br /><br /><br /></pre></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>