<div dir="ltr">Hi Eric, I think this change or one of your subsequent changes broke the sanitizer-x86_64-linux-fast bot.<div><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/16536">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/16536</a><br></div><div>Can you please take a look?</div><div><br></div><div>Peter</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 20, 2016 at 9:04 AM, Eric Christopher via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: echristo<br>
Date: Tue Sep 20 11:04:50 2016<br>
New Revision: 281981<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=281981&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=281981&view=rev</a><br>
Log:<br>
Remove extra argument used once on TargetMachine::<wbr>getNameWithPrefix and inline the result into the singular caller.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/<wbr>Target/TargetMachine.h<br>
    llvm/trunk/lib/CodeGen/<wbr>TargetLoweringObjectFileImpl.<wbr>cpp<br>
    llvm/trunk/lib/Target/<wbr>TargetMachine.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/<wbr>Target/TargetMachine.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetMachine.h?rev=281981&r1=281980&r2=281981&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/Target/TargetMachine.h?<wbr>rev=281981&r1=281980&r2=<wbr>281981&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/<wbr>Target/TargetMachine.h (original)<br>
+++ llvm/trunk/include/llvm/<wbr>Target/TargetMachine.h Tue Sep 20 11:04:50 2016<br>
@@ -265,7 +265,7 @@ public:<br>
   virtual bool targetSchedulesPostRASchedulin<wbr>g() const { return false; };<br>
<br>
   void getNameWithPrefix(<wbr>SmallVectorImpl<char> &Name, const GlobalValue *GV,<br>
-                         Mangler &Mang, bool MayAlwaysUsePrivate = false) const;<br>
+                         Mangler &Mang) const;<br>
   MCSymbol *getSymbol(const GlobalValue *GV, Mangler &Mang) const;<br>
<br>
   /// True if the target uses physical regs at Prolog/Epilog insertion<br>
<br>
Modified: llvm/trunk/lib/CodeGen/<wbr>TargetLoweringObjectFileImpl.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp?rev=281981&r1=281980&r2=281981&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>CodeGen/<wbr>TargetLoweringObjectFileImpl.<wbr>cpp?rev=281981&r1=281980&r2=<wbr>281981&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/CodeGen/<wbr>TargetLoweringObjectFileImpl.<wbr>cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/<wbr>TargetLoweringObjectFileImpl.<wbr>cpp Tue Sep 20 11:04:50 2016<br>
@@ -296,7 +296,7 @@ selectELFSectionForGlobal(<wbr>MCContext &Ctx<br>
<br>
   if (EmitUniqueSection && UniqueSectionNames) {<br>
     Name.push_back('.');<br>
-    TM.getNameWithPrefix(Name, GV, Mang, true);<br>
+    Mang.getNameWithPrefix(Name, GV, false);<br>
   }<br>
   unsigned UniqueID = MCContext::GenericSectionID;<br>
   if (EmitUniqueSection && !UniqueSectionNames) {<br>
<br>
Modified: llvm/trunk/lib/Target/<wbr>TargetMachine.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetMachine.cpp?rev=281981&r1=281980&r2=281981&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>TargetMachine.cpp?rev=281981&<wbr>r1=281980&r2=281981&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Target/<wbr>TargetMachine.cpp (original)<br>
+++ llvm/trunk/lib/Target/<wbr>TargetMachine.cpp Tue Sep 20 11:04:50 2016<br>
@@ -199,9 +199,8 @@ TargetIRAnalysis TargetMachine::getTarge<br>
 }<br>
<br>
 void TargetMachine::<wbr>getNameWithPrefix(<wbr>SmallVectorImpl<char> &Name,<br>
-                                      const GlobalValue *GV, Mangler &Mang,<br>
-                                      bool MayAlwaysUsePrivate) const {<br>
-  if (MayAlwaysUsePrivate || !GV->hasPrivateLinkage()) {<br>
+                                      const GlobalValue *GV, Mangler &Mang) const {<br>
+  if (!GV->hasPrivateLinkage()) {<br>
     // Simple case: If GV is not private, it is not important to find out if<br>
     // private labels are legal in this case or not.<br>
     Mang.getNameWithPrefix(Name, GV, false);<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>