<div dir="ltr">Reverted here:<div><br></div><div><div>Committing to <a href="https://llvm.org/svn/llvm-project/llvm/trunk">https://llvm.org/svn/llvm-project/llvm/trunk</a> ...</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>M<span class="Apple-tab-span" style="white-space:pre"> </span>include/llvm/Target/TargetMachine.h</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>M<span class="Apple-tab-span" style="white-space:pre"> </span>lib/CodeGen/TargetLoweringObjectFileImpl.cpp</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>M<span class="Apple-tab-span" style="white-space:pre"> </span>lib/Target/TargetMachine.cpp</div><div>Committed r282028</div></div><div><br></div><div>I'll need to do a bit more work to untangle this mess.</div><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Sep 20, 2016 at 2:38 PM Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">I'll take a look.<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Also, darn.</div></div><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">-eric</div></div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Tue, Sep 20, 2016 at 2:31 PM Peter Collingbourne <<a href="mailto:peter@pcc.me.uk" class="gmail_msg" target="_blank">peter@pcc.me.uk</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Hi Eric, I think this change or one of your subsequent changes broke the sanitizer-x86_64-linux-fast bot.<div class="gmail_msg"><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/16536" class="gmail_msg" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/16536</a><br class="gmail_msg"></div><div class="gmail_msg">Can you please take a look?</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Peter</div></div><div class="gmail_extra gmail_msg"></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Tue, Sep 20, 2016 at 9:04 AM, Eric Christopher via llvm-commits <span dir="ltr" class="gmail_msg"><<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: echristo<br class="gmail_msg">
Date: Tue Sep 20 11:04:50 2016<br class="gmail_msg">
New Revision: 281981<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=281981&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=281981&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Remove extra argument used once on TargetMachine::getNameWithPrefix and inline the result into the singular caller.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
llvm/trunk/include/llvm/Target/TargetMachine.h<br class="gmail_msg">
llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp<br class="gmail_msg">
llvm/trunk/lib/Target/TargetMachine.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/include/llvm/Target/TargetMachine.h<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetMachine.h?rev=281981&r1=281980&r2=281981&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetMachine.h?rev=281981&r1=281980&r2=281981&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/include/llvm/Target/TargetMachine.h (original)<br class="gmail_msg">
+++ llvm/trunk/include/llvm/Target/TargetMachine.h Tue Sep 20 11:04:50 2016<br class="gmail_msg">
@@ -265,7 +265,7 @@ public:<br class="gmail_msg">
virtual bool targetSchedulesPostRAScheduling() const { return false; };<br class="gmail_msg">
<br class="gmail_msg">
void getNameWithPrefix(SmallVectorImpl<char> &Name, const GlobalValue *GV,<br class="gmail_msg">
- Mangler &Mang, bool MayAlwaysUsePrivate = false) const;<br class="gmail_msg">
+ Mangler &Mang) const;<br class="gmail_msg">
MCSymbol *getSymbol(const GlobalValue *GV, Mangler &Mang) const;<br class="gmail_msg">
<br class="gmail_msg">
/// True if the target uses physical regs at Prolog/Epilog insertion<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp?rev=281981&r1=281980&r2=281981&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp?rev=281981&r1=281980&r2=281981&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp Tue Sep 20 11:04:50 2016<br class="gmail_msg">
@@ -296,7 +296,7 @@ selectELFSectionForGlobal(MCContext &Ctx<br class="gmail_msg">
<br class="gmail_msg">
if (EmitUniqueSection && UniqueSectionNames) {<br class="gmail_msg">
Name.push_back('.');<br class="gmail_msg">
- TM.getNameWithPrefix(Name, GV, Mang, true);<br class="gmail_msg">
+ Mang.getNameWithPrefix(Name, GV, false);<br class="gmail_msg">
}<br class="gmail_msg">
unsigned UniqueID = MCContext::GenericSectionID;<br class="gmail_msg">
if (EmitUniqueSection && !UniqueSectionNames) {<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/Target/TargetMachine.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetMachine.cpp?rev=281981&r1=281980&r2=281981&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetMachine.cpp?rev=281981&r1=281980&r2=281981&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Target/TargetMachine.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/lib/Target/TargetMachine.cpp Tue Sep 20 11:04:50 2016<br class="gmail_msg">
@@ -199,9 +199,8 @@ TargetIRAnalysis TargetMachine::getTarge<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
void TargetMachine::getNameWithPrefix(SmallVectorImpl<char> &Name,<br class="gmail_msg">
- const GlobalValue *GV, Mangler &Mang,<br class="gmail_msg">
- bool MayAlwaysUsePrivate) const {<br class="gmail_msg">
- if (MayAlwaysUsePrivate || !GV->hasPrivateLinkage()) {<br class="gmail_msg">
+ const GlobalValue *GV, Mangler &Mang) const {<br class="gmail_msg">
+ if (!GV->hasPrivateLinkage()) {<br class="gmail_msg">
// Simple case: If GV is not private, it is not important to find out if<br class="gmail_msg">
// private labels are legal in this case or not.<br class="gmail_msg">
Mang.getNameWithPrefix(Name, GV, false);<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div><br class="gmail_msg"><br clear="all" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div></div><div class="gmail_extra gmail_msg">-- <br class="gmail_msg"><div class="m_-1654824799203507903m_-5838188329013222308gmail_signature gmail_msg" data-smartmail="gmail_signature"><div dir="ltr" class="gmail_msg">-- <div class="gmail_msg">Peter</div></div></div>
</div></blockquote></div></blockquote></div>