<div dir="ltr">Please, can we have if() instead of #if? </div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 20, 2016 at 6:28 AM, Dmitry Vyukov via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dvyukov<br>
Date: Tue Sep 20 08:28:20 2016<br>
New Revision: 281969<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=281969&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=281969&view=rev</a><br>
Log:<br>
tsan: make CHECK more robust<br>
<br>
Enable more ignores when we start crashing.<br>
Unwind in CHECK SIGSEGVs if happens early:<br>
<br>
FATAL: ThreadSanitizer CHECK failed: ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_platform_posix.<wbr>cc:105 "((beg)) <= ((end))" (0x8000000000, 0x4000000000)<br>
Program received signal SIGSEGV, Segmentation fault.<br>
__tsan::MetaMap::GetAndLock (this=0x1337c88 <__tsan::ctx_placeholder+8>, thr=thr@entry=0x7ffff7f91800, pc=pc@entry=4639488, addr=addr@entry=<wbr>140737339086992, write_lock=write_lock@entry=<wbr>true,<br>
create=create@entry=true) at ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_sync.cc:208<br>
208 u32 idx0 = *meta;<br>
(gdb) bt<br>
#0 __tsan::MetaMap::GetAndLock (this=0x1337c88 <__tsan::ctx_placeholder+8>, thr=thr@entry=0x7ffff7f91800, pc=pc@entry=4639488, addr=addr@entry=<wbr>140737339086992, write_lock=write_lock@entry=<wbr>true,<br>
create=create@entry=true) at ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_sync.cc:208<br>
#1 0x00000000004a965f in __tsan::MetaMap::<wbr>GetOrCreateAndLock (this=<optimized out>, thr=thr@entry=0x7ffff7f91800, pc=pc@entry=4639488, addr=addr@entry=<wbr>140737339086992, write_lock=write_lock@entry=<wbr>true)<br>
at ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_sync.cc:198<br>
#2 0x00000000004a162a in __tsan::Release (thr=0x7ffff7f91800, pc=pc@entry=4639488, addr=addr@entry=<wbr>140737339086992) at ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_rtl_mutex.cc:395<br>
#3 0x000000000046cc40 in __interceptor_pthread_once (o=0x7ffff71a5890 <once_regsizes>, f=0x7ffff6f9d9c0 <init_dwarf_reg_size_table>) at ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_interceptors.cc:<wbr>1334<br>
#4 0x00007ffff6f9fe86 in __gthread_once (__func=0x7ffff6f9d9c0 <init_dwarf_reg_size_table>, __once=0x7ffff71a5890 <once_regsizes>) at ./gthr-default.h:699<br>
#5 uw_init_context_1 (context=context@entry=<wbr>0x7fffffffd6d0, outer_cfa=outer_cfa@entry=<wbr>0x7fffffffd980, outer_ra=0x437d13 <__sanitizer::<wbr>BufferedStackTrace::<wbr>SlowUnwindStack(unsigned long, unsigned int)+67>)<br>
at ../../../src/libgcc/unwind-<wbr>dw2.c:1572<br>
#6 0x00007ffff6fa06a8 in _Unwind_Backtrace (trace=0x437c30 <__sanitizer::Unwind_Trace(_<wbr>Unwind_Context*, void*)>, trace_argument=0x7fffffffd980) at ../../../src/libgcc/unwind.<wbr>inc:283<br>
#7 0x0000000000437d13 in __sanitizer::<wbr>BufferedStackTrace::<wbr>SlowUnwindStack (this=0x7ffff6103208, pc=pc@entry=4863574, max_depth=max_depth@entry=256)<br>
at ../projects/compiler-rt/lib/<wbr>sanitizer_common/sanitizer_<wbr>unwind_linux_libcdep.cc:125<br>
#8 0x0000000000434f4a in __sanitizer::<wbr>BufferedStackTrace::Unwind (this=this@entry=<wbr>0x7ffff6103208, max_depth=max_depth@entry=256, pc=pc@entry=4863574, bp=bp@entry=0, context=context@entry=0x0,<br>
stack_top=stack_top@entry=0, stack_bottom=stack_bottom@<wbr>entry=0, request_fast_unwind=request_<wbr>fast_unwind@entry=false) at ../projects/compiler-rt/lib/<wbr>sanitizer_common/sanitizer_<wbr>stacktrace_libcdep.cc:76<br>
#9 0x00000000004a36b3 in PrintCurrentStackSlow (pc=4863574) at ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_rtl_report.cc:<wbr>696<br>
#10 __tsan::TsanCheckFailed (file=<optimized out>, line=<optimized out>, cond=<optimized out>, v1=<optimized out>, v2=<optimized out>) at ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_rtl_report.cc:44<br>
#11 0x000000000042dfd6 in __sanitizer::CheckFailed (file=file@entry=0x4b9fd0 "../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_platform_posix.<wbr>cc", line=line@entry=105,<br>
cond=cond@entry=0x4ba049 "((beg)) <= ((end))", v1=v1@entry=549755813888, v2=v2@entry=274877906944) at ../projects/compiler-rt/lib/<wbr>sanitizer_common/sanitizer_<wbr>termination.cc:79<br>
#12 0x00000000004aa36c in ProtectRange (end=274877906944, beg=549755813888) at ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_platform_posix.<wbr>cc:105<br>
#13 __tsan::CheckAndProtect () at ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_platform_posix.<wbr>cc:133<br>
#14 0x00000000004a9e95 in __tsan::InitializePlatform () at ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_platform_linux.<wbr>cc:280<br>
#15 0x0000000000497e73 in __tsan::Initialize (thr=0x7ffff7f91800) at ../projects/compiler-rt/lib/<wbr>tsan/rtl/tsan_rtl.cc:343<br>
#16 0x00007ffff7dea25a in _dl_init (main_map=0x7ffff7ffe1c8, argc=1, argv=0x7fffffffdb88, env=0x7fffffffdb98) at dl-init.c:111<br>
#17 0x00007ffff7ddb30a in _dl_start_user () at rtld.c:871<br>
<br>
<br>
Modified:<br>
compiler-rt/trunk/lib/tsan/<wbr>rtl/tsan_rtl_report.cc<br>
<br>
Modified: compiler-rt/trunk/lib/tsan/<wbr>rtl/tsan_rtl_report.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_report.cc?rev=281969&r1=281968&r2=281969&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/lib/<wbr>tsan/rtl/tsan_rtl_report.cc?<wbr>rev=281969&r1=281968&r2=<wbr>281969&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/lib/tsan/<wbr>rtl/tsan_rtl_report.cc (original)<br>
+++ compiler-rt/trunk/lib/tsan/<wbr>rtl/tsan_rtl_report.cc Tue Sep 20 08:28:20 2016<br>
@@ -38,6 +38,10 @@ void TsanCheckFailed(const char *file, i<br>
// on the other hand there is no sense in processing interceptors<br>
// since we are going to die soon.<br>
ScopedIgnoreInterceptors ignore;<br>
+#ifndef SANITIZER_GO<br>
+ cur_thread()->ignore_sync++;<br>
+ cur_thread()->ignore_reads_<wbr>and_writes++;<br>
+#endif<br>
Printf("FATAL: ThreadSanitizer CHECK failed: "<br>
"%s:%d \"%s\" (0x%zx, 0x%zx)\n",<br>
file, line, cond, (uptr)v1, (uptr)v2);<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>