<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p><span style="color: rgb(33, 33, 33); font-size: 12pt;">></span><span style="color: rgb(33, 33, 33); font-size: 12pt;">Can you add a comment saying that list is used to avoid a compiler (libc++?) bug? std::vector is far more common, so it is nice to justify
why a list is used.</span><br>
</p>
<div style="color: rgb(33, 33, 33);">
<div>
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>> </div>
<div>> </div>
<div>>Thanks,</div>
<div>>Rafael</div>
<div><br>
</div>
<div>
<p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">Rui already changed that place in r<span style="font-size: 12pt;">281803, to use struct instead of pair,</span></p>
<p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;"><span style="font-size: 12pt;">but seems also had problems with vector (see <span style="background-color: rgb(255, 255, 255);"></span><span style="font-size: 12pt; background-color: rgb(255, 255, 255);">r<span style="font-size: 12pt;">281805</span>)</span>,
as comment now says:</span></p>
<p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;"><span style="font-size: 12pt;"><br>
</span></p>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
// We use std::list instead of std::vector because SectionPattern</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
// do not support move assignment.<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
I am not sure it is correct comment though, as I think struct without anything like desctructors,<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
and just that has 2 movable fields should be movable.<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
There is no link on buildbot in commit message for 281805, </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
I`ll check if swiching to struct helped my FreeBSD VM where It was reproducible.<br>
</div>
<p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;"><br>
</p>
<p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">George.<br>
</p>
<br>
</div>
<div> </div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>