<div dir="ltr">testcase?</div><div class="gmail_extra"><br><div class="gmail_quote">On 19 September 2016 at 08:19, Simon Dardis via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">sdardis created this revision.<br>
sdardis added a subscriber: llvm-commits.<br>
Herald added a reviewer: vkalintiris.<br>
<br>
When parsing assembly text directives such as .local, .weak, the symbols were<br>
not marked as such in the internal symbol table. This lead to different output<br>
depending on whether MCAsmStreamer or MCELFStreamer was. This patch<br>
corrects such behaviour.<br>
<br>
<a href="https://reviews.llvm.org/D24721" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D24721</a><br>
<br>
Files:<br>
  lib/MC/MCParser/ELFAsmParser.<wbr>cpp<br>
<br>
Index: lib/MC/MCParser/ELFAsmParser.<wbr>cpp<br>
==============================<wbr>==============================<wbr>=======<br>
--- lib/MC/MCParser/ELFAsmParser.<wbr>cpp<br>
+++ lib/MC/MCParser/ELFAsmParser.<wbr>cpp<br>
@@ -166,6 +166,12 @@<br>
<br>
       MCSymbol *Sym = getContext().<wbr>getOrCreateSymbol(Name);<br>
<br>
+      if (Attr == MCSA_Local) {<br>
+        cast<MCSymbolELF>(Sym)-><wbr>setBinding(ELF::STB_LOCAL);<br>
+      } else if (Attr == MCSA_Weak) {<br>
+        cast<MCSymbolELF>(Sym)-><wbr>setBinding(ELF::STB_WEAK);<br>
+      }<br>
+<br>
       getStreamer().<wbr>EmitSymbolAttribute(Sym, Attr);<br>
<br>
       if (getLexer().is(AsmToken::<wbr>EndOfStatement))<br>
<br>
<br>
<br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>