<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 15, 2016, at 9:35 AM, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com" class="">rafael.espindola@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">BTW, that doesn't seem to be the only issue.<br class=""><br class=""></div><div class="">Right now patatino gets internalized, which fails the verifier, that would be fixed by pr30396 or some workaround.<br class=""><br class=""></div><div class="">But, adding -upatatino to the command line causes gold to fail because foo is internalized. I can't quite make what is the code path that is missing, but nothing creates the llvm.compiler.used that should prevent foo from being removed.<br class=""></div></div></div></blockquote><div><br class=""></div><div>Indeed, it looks like the call to updateCompilerUsed got lost in the new API…</div><div><br class=""></div><div>Teresa: for ThinLTO it got lost when you moved to the index-based internalization in <a href="http://reviews.llvm.org/D20290" class="">http://reviews.llvm.org/D20290</a> I believe.</div><div><br class=""></div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">Cheers,<br class=""></div><div class="">Rafael<br class=""><br class=""></div><div class=""><br class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On 15 September 2016 at 11:27, Rafael Espíndola <span dir="ltr" class=""><<a href="mailto:rafael.espindola@gmail.com" target="_blank" class="">rafael.espindola@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><span class=""></span><br class=""><span class=""></span><div class="gmail_extra"><div class="gmail_quote"><span class=""><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><span class="">
</span>Yes that sounds the proper fix: we should have llvm-nm report the correct list for instance.<br class=""></blockquote><div class=""><br class=""></div></span><div class="">Reported <a href="https://llvm.org/bugs/show_bug.cgi?id=30396" target="_blank" class="">https://llvm.org/bugs/show_<wbr class="">bug.cgi?id=30396</a> to track it.<br class=""><br class=""></div><div class="">Cheers,<br class=""></div><div class="">Rafael<br class=""> <br class=""></div></div></div></div>
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>