<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 15, 2016, at 10:17 AM, Teresa Johnson <<a href="mailto:tejohnson@google.com" class="">tejohnson@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Thu, Sep 15, 2016 at 9:44 AM, Mehdi Amini<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:mehdi.amini@apple.com" target="_blank" class="">mehdi.amini@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><br class=""><div class=""><span class="gmail-"><blockquote type="cite" class=""><div class="">On Sep 15, 2016, at 9:35 AM, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com" target="_blank" class="">rafael.espindola@gmail.com</a>> wrote:</div><br class="gmail-m_-394393638303517582Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">BTW, that doesn't seem to be the only issue.<br class=""><br class=""></div><div class="">Right now patatino gets internalized, which fails the verifier, that would be fixed by pr30396 or some workaround.<br class=""><br class=""></div><div class="">But, adding -upatatino to the command line causes gold to fail because foo is internalized. I can't quite make what is the code path that is missing, but nothing creates the llvm.compiler.used that should prevent foo from being removed.<br class=""></div></div></div></blockquote><div class=""><br class=""></div></span><div class="">Indeed, it looks like the call to updateCompilerUsed got lost in the new API…</div><div class=""><br class=""></div><div class="">Teresa: for ThinLTO it got lost when you moved to the index-based internalization in <a href="http://reviews.llvm.org/D20290" target="_blank" class="">http://reviews.llvm.org/<wbr class="">D20290</a><span class="Apple-converted-space"> </span>I believe.</div></div></div></blockquote><div class=""><br class=""></div><div class="">Do we need that for ThinLTO? Note the AsmUndefinedRefs are being preserved via the MustPreserveGV callback thinLTOInternalizeModule.</div></div></div></blockquote><div><br class=""></div><div>I’m not totally sure: what if the function or variable is already internal before?</div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><div class=""><span class="gmail-"><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On 15 September 2016 at 11:27, Rafael Espíndola<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:rafael.espindola@gmail.com" target="_blank" class="">rafael.espindola@gmail.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class=""><span class=""></span><br class=""><span class=""></span><div class="gmail_extra"><div class="gmail_quote"><span class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><span class=""></span>Yes that sounds the proper fix: we should have llvm-nm report the correct list for instance.<br class=""></blockquote><div class=""><br class=""></div></span><div class="">Reported<span class="Apple-converted-space"> </span><a href="https://llvm.org/bugs/show_bug.cgi?id=30396" target="_blank" class="">https://llvm.org/bugs/show_bug<wbr class="">.cgi?id=30396</a><span class="Apple-converted-space"> </span>to track it.<br class=""><br class=""></div><div class="">Cheers,<br class=""></div><div class="">Rafael<br class=""> <br class=""></div></div></div></div></blockquote></div><br class=""></div></div></blockquote></span></div><br class=""></div></blockquote></div><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br clear="all" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">--<span class="Apple-converted-space"> </span></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_signature" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span style="font-family: times; font-size: inherit;" class=""><table cellspacing="0" cellpadding="0" class=""><tbody class=""><tr style="color: rgb(85, 85, 85); font-family: sans-serif; font-size: small;" class=""><td nowrap="" style="border-top-width: 2px; border-top-style: solid; border-top-color: rgb(213, 15, 37);" class="">Teresa Johnson |</td><td nowrap="" style="border-top-width: 2px; border-top-style: solid; border-top-color: rgb(51, 105, 232);" class=""> Software Engineer |</td><td nowrap="" style="border-top-width: 2px; border-top-style: solid; border-top-color: rgb(0, 153, 57);" class=""> <a href="mailto:tejohnson@google.com" target="_blank" class="">tejohnson@google.com</a> |</td><td nowrap="" style="border-top-width: 2px; border-top-style: solid; border-top-color: rgb(238, 178, 17);" class=""> 408-460-2413</td></tr></tbody></table></span></div></div></blockquote></div><br class=""></body></html>