<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 15, 2016 at 11:16 AM, Teresa Johnson via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><div> </div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote"><span>On Thu, Sep 15, 2016 at 10:40 AM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><div><br></div></span><div>Not sure I understand the question. We were previously calling UpdateCompilerUsed before invoking llvm::internalizeModule, presumably to prevent internalization. Now we simply use the callback to query this information directly.</div><span><div><br></div></span></div></div></div></blockquote><div><br></div></span><div>Note that in the case of assembly uses, we don't want to prevent internalization, we want to prevent the internalized symbol from being deleted.</div></div></div></div></blockquote><div><br></div></span><div>I see, so we need to call that routine to update the llvm.compiler.used regardless of internalization. Which means I should put it back in lto::thinBackend, not in thinLTOInternalizeModule.</div><div><br></div><div>And presumably lto::backend() should get an instance of it too?</div><br></div></div></div></blockquote></div><br></div><div class="gmail_extra"><a href="https://reviews.llvm.org/D24617(for" target="_blank">https://reviews.llvm.org/<wbr>D24617(for</a> the backed part). I thought we needed this in lld, so it was in my local tree. <br clear="all"></div><div class="gmail_extra"><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Davide<br><br>"There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare</div>
</div></div>