<div dir="ltr">Thanks for the cleanup.<div>Teresa</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 13, 2016 at 7:55 PM, Peter Collingbourne via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: pcc<br>
Date: Tue Sep 13 21:55:16 2016<br>
New Revision: 281437<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=281437&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=281437&view=rev</a><br>
Log:<br>
gold: Simplify. Do not unnecessarily enumerate Obj's symbols.<br>
<br>
Modified:<br>
    llvm/trunk/tools/gold/gold-<wbr>plugin.cpp<br>
<br>
Modified: llvm/trunk/tools/gold/gold-<wbr>plugin.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=281437&r1=281436&r2=281437&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/gold/<wbr>gold-plugin.cpp?rev=281437&r1=<wbr>281436&r2=281437&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/tools/gold/gold-<wbr>plugin.cpp (original)<br>
+++ llvm/trunk/tools/gold/gold-<wbr>plugin.cpp Tue Sep 13 21:55:16 2016<br>
@@ -568,14 +568,10 @@ static void addModule(LTO &Lto, claimed_<br>
     message(LDPL_FATAL, "Could not read bitcode from file : %s",<br>
             toString(ObjOrErr.takeError())<wbr>.c_str());<br>
<br>
-  InputFile &Obj = **ObjOrErr;<br>
-<br>
   unsigned SymNum = 0;<br>
   std::vector<SymbolResolution> Resols(F.syms.size());<br>
-  for (LLVM_ATTRIBUTE_UNUSED auto &ObjSym : Obj.symbols()) {<br>
-    ld_plugin_symbol &Sym = F.syms[SymNum];<br>
-    SymbolResolution &R = Resols[SymNum];<br>
-    ++SymNum;<br>
+  for (ld_plugin_symbol &Sym : F.syms) {<br>
+    SymbolResolution &R = Resols[SymNum++];<br>
<br>
     ld_plugin_symbol_resolution Resolution =<br>
         (ld_plugin_symbol_resolution)<wbr>Sym.resolution;<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div>