<html><head></head><body>Lgtm. <br> <br><div class="bloop_sign"></div> <p class="gmail_quote" style="color:#000;">On September 13, 2016 at 6:10:10 PM, Vedant Kumar (<a href="mailto:vsk@apple.com">vsk@apple.com</a>) wrote:</p> <blockquote type="cite" class="gmail_quote"><span><div><div></div><div>vsk created this revision.

<br>vsk added a reviewer: cmatthews.

<br>vsk added a subscriber: llvm-commits.

<br>Herald added a subscriber: dberris.

<br>

<br>build.py tars up the cmake build products to create an artifact, but it excludes all .a files. That means that the resulting compiler artifacts aren't prepped with any compiler-rt runtimes.

<br>

<br>Be more selective about the .a files we exclude.

<br>

<br>https://reviews.llvm.org/D24539

<br>

<br>Files:

<br>  zorg/jenkins/build.py

<br>

<br>Index: zorg/jenkins/build.py

<br>===================================================================

<br>--- zorg/jenkins/build.py

<br>+++ zorg/jenkins/build.py

<br>@@ -672,8 +672,10 @@

<br>         prop_fd.write("LLVM_REV={}\n".format(conf.svn_rev))

<br>         prop_fd.write("ARTIFACT={}\n".format(new_url))

<br>  

<br>-    # The .a's are big and we don't need them later. Drop them.

<br>-    tar = ["tar", "zcvf", "../" + artifact_name, '--exclude=*.a',  "."]

<br>+    # The .a's are big and we don't need them later. Drop the LLVM and clang

<br>+    # libraries, but keep the libraries from compiler-rt.

<br>+    tar = ["tar", "zcvf", "../" + artifact_name, "--exclude=*libLLVM*.a",

<br>+           "--exclude=*libclang[A-Z]*.a", "."]

<br>  

<br>     run_cmd(conf.installdir(), tar)

<br>  

<br>

<br>

<br><hr></div></div></span></blockquote></body></html>