<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 12, 2016, at 9:03 PM, Davide Italiano <<a href="mailto:davide@freebsd.org" class="">davide@freebsd.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><p dir="ltr" class="">On Sep 12, 2016 8:51 PM, "Mehdi Amini" <<a href="mailto:mehdi.amini@apple.com" class="">mehdi.amini@apple.com</a>> wrote:<br class="">
><br class="">
><br class="">
><br class="">
> Sent from my iPhone<br class="">
><br class="">
> On Sep 12, 2016, at 8:13 PM, Davide Italiano <<a href="mailto:davide@freebsd.org" class="">davide@freebsd.org</a>> wrote:<br class="">
><br class="">
>> On Mon, Sep 12, 2016 at 8:05 PM, Mehdi Amini <<a href="mailto:mehdi.amini@apple.com" class="">mehdi.amini@apple.com</a>> wrote:<br class="">
>>><br class="">
>>> Sneaky ping on<a href="https://reviews.llvm.org/D23132" class=""> https://reviews.llvm.org/D23132</a> :)<br class="">
>>><br class="">
>>><br class="">
>>> (In the meantime: +1 to Peter, please revert)<br class="">
>>><br class="">
>>><br class="">
>><br class="">
>> This patch is not breaking any buildbot<br class="">
><br class="">
><br class="">
> That's not a criteria.<br class="">
><br class="">
>> and it's very unlikely that's<br class="">
>> is gonna be used by anything outside of lld<br class="">
><br class="">
><br class="">
> As long as I delete this API without updating your client code, that's fine with me.<br class=""></p><p dir="ltr" class="">hmm. We already had this discussion when Peter tried to implement ThinLTO in lld. I don't think it's acceptable because we should all try to keep the bots green and happy. I think, instead, you might want to consider and comment on my idea of moving the check inside the library, checking if that would break any of your use cases.</p></div></blockquote><div>Right, we can discuss whatever you want. But right now you need to revert this API, it is not acceptable in the first place.</div><div><br class=""></div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div></div></body></html>