<div dir="ltr">To clarify: the test is enabled and running. It just does not make the bot red. Notice the yellow stage here: <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/25080">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/25080</a></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 9, 2016 at 6:19 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>+James Molloy, dvyukov</div><div><br></div>Ooook... <div><br></div><div>Looks like there are lots of reasons to not revert the change that regressed this. (<a href="https://llvm.org/bugs/show_bug.cgi?id=30244" target="_blank">https://llvm.org/bugs/show_<wbr>bug.cgi?id=30244</a>)</div><div>Ivan, may I ask you modify the test so that it passes now and enable it back? </div><div>This way we'll at least know if it regresses further and also if it improves. </div><div><br></div><div>--kcc </div><div><br></div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 8, 2016 at 3:26 PM, Ivan Krasin <span dir="ltr"><<a href="mailto:krasin@google.com" target="_blank">krasin@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Not yet. The codegen bug is still not fixed: <a href="https://llvm.org/bugs/show_bug.cgi?id=30244" target="_blank">https://llvm.org/bugs/s<wbr>how_bug.cgi?id=30244</a> and the issue still happening: <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/25007/steps/tsan%20analyze/logs/stdio" target="_blank">http://lab.llvm.org<wbr>:8011/builders/sanitizer-x86_<wbr>64-linux-autoconf/builds/25007<wbr>/steps/tsan%20analyze/logs/<wbr>stdio</a><div><br><div>Dmitry Vyukov posted a short reproducer today, that should help with tracking down the regression.</div><div>After the bug is closed, I will revert my CL.</div></div></div><div class="m_3232739240764651922HOEnZb"><div class="m_3232739240764651922h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 8, 2016 at 2:53 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">can this be reverted now? </div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 6, 2016 at 3:19 PM, Ivan Krasin via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: krasin<br>
Date: Tue Sep  6 17:19:30 2016<br>
New Revision: 280761<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=280761&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=280761&view=rev</a><br>
Log:<br>
Downgrade tsan_analyze step to warnings to fix the bot<br>
<br>
Summary:<br>
tsan_analyze identified a codegen regression that is being<br>
discussed in <a href="https://llvm.org/bugs/show_bug.cgi?id=30244" rel="noreferrer" target="_blank">https://llvm.org/bugs/show_bug<wbr>.cgi?id=30244</a>.<br>
This change downgrades the check from failure to warnings to<br>
make the bot happy.<br>
<br>
Reviewers: dvyukov<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D24281" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2428<wbr>1</a><br>
<br>
Modified:<br>
    zorg/trunk/zorg/buildbot/build<wbr>ers/sanitizers/buildbot_standa<wbr>rd.sh<br>
<br>
Modified: zorg/trunk/zorg/buildbot/build<wbr>ers/sanitizers/buildbot_standa<wbr>rd.sh<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_standard.sh?rev=280761&r1=280760&r2=280761&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/zorg/trunk/zorg/buildbot<wbr>/builders/sanitizers/buildbot_<wbr>standard.sh?rev=280761&r1=2807<wbr>60&r2=280761&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- zorg/trunk/zorg/buildbot/build<wbr>ers/sanitizers/buildbot_standa<wbr>rd.sh (original)<br>
+++ zorg/trunk/zorg/buildbot/build<wbr>ers/sanitizers/buildbot_standa<wbr>rd.sh Tue Sep  6 17:19:30 2016<br>
@@ -64,4 +64,4 @@ build_tsan "${TSAN_RELEASE_BUILD_DIR}" "<br>
 echo @@@BUILD_STEP tsan analyze@@@<br>
 BIN=$(mktemp -t tsan_exe.XXXXXXXX)<br>
 echo "int main() {return 0;}" | $TSAN_RELEASE_BUILD_DIR/bin/cl<wbr>ang -x c++ - -fsanitize=thread -O2 -o ${BIN}<br>
-$LLVM_CHECKOUT/projects/compi<wbr>ler-rt/lib/tsan/check_analyze.<wbr>sh ${BIN} || echo @@@STEP_FAILURE@@@<br>
+$LLVM_CHECKOUT/projects/compi<wbr>ler-rt/lib/tsan/check_analyze.<wbr>sh ${BIN} || echo @@@STEP_WARNINGS@@@<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>