<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 9, 2016 at 10:50 AM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I think it is worse than using msan because if you initialize a variable with a dummy value and forget to set to a correct value, you'll get a mysterious error, and msan can't help debugging.</div></blockquote><div><br></div><div>Not if you place an assert / report_fatal_error ;)</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 8, 2016 at 8:28 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Can you add an assertion that would catch this without msan? (e.g. initialize to a sentinel value and assert that the target overrides it)<span><font color="#888888"><div><br></div><div>-- Sean Silva</div></font></span></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 31, 2016 at 2:04 PM, Rui Ueyama via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Wed Aug 31 16:04:25 2016<br>
New Revision: 280291<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=280291&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=280291&view=rev</a><br>
Log:<br>
Initialize RelativeRel for AMDGPU.<br>
<br>
Target->RelativeRel is used for all platforms, but AMDGPU did<br>
not send that member.<br>
<br>
Fixes bug 30227 - RelativeRel is used, but not initialized for AMDGPU.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D24100" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2410<wbr>0</a><br>
<br>
Modified:<br>
    lld/trunk/ELF/Target.cpp<br>
<br>
Modified: lld/trunk/ELF/Target.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=280291&r1=280290&r2=280291&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/lld/trunk/ELF/Target.cpp<wbr>?rev=280291&r1=280290&r2=28029<wbr>1&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/Target.cpp (original)<br>
+++ lld/trunk/ELF/Target.cpp Wed Aug 31 16:04:25 2016<br>
@@ -1457,6 +1457,7 @@ void AArch64TargetInfo::relaxTlsIeT<wbr>oLe(u<br>
 }<br>
<br>
 AMDGPUTargetInfo::AMDGPUTarge<wbr>tInfo() {<br>
+  RelativeRel = R_AMDGPU_REL64;<br>
   GotRel = R_AMDGPU_ABS64;<br>
   GotEntrySize = 8;<br>
 }<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>