<div dir="ltr">Is hasSideEffects and mayLoad being inferred from the other pattern?</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div>
<br><div class="gmail_quote">On Thu, Sep 1, 2016 at 7:59 AM, Simon Pilgrim via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rksimon<br>
Date: Thu Sep  1 09:59:20 2016<br>
New Revision: 280376<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=280376&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=280376&view=rev</a><br>
Log:<br>
[X86][SSE] Dropped (V)CVTPD2PS intrinsic patterns now that its bound to X86vfpround<br>
<br>
It now uses X86vfpround patterns directly instead.<br>
<br>
Followup to D23797<br>
<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/<wbr>X86InstrSSE.td<br>
<br>
Modified: llvm/trunk/lib/Target/X86/<wbr>X86InstrSSE.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrSSE.td?rev=280376&r1=280375&r2=280376&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>X86/X86InstrSSE.td?rev=280376&<wbr>r1=280375&r2=280376&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Target/X86/<wbr>X86InstrSSE.td (original)<br>
+++ llvm/trunk/lib/Target/X86/<wbr>X86InstrSSE.td Thu Sep  1 09:59:20 2016<br>
@@ -2239,17 +2239,14 @@ let Predicates = [HasSSE2] in {<br>
 // Provide other assembly rr and rm forms to address this explicitly.<br>
 def VCVTPD2PSrr : VPDI<0x5A, MRMSrcReg, (outs VR128:$dst), (ins VR128:$src),<br>
                        "cvtpd2ps\t{$src, $dst|$dst, $src}",<br>
-                       [(set VR128:$dst, (int_x86_sse2_cvtpd2ps VR128:$src))],<br>
-                       IIC_SSE_CVT_PD_RR>, VEX, Sched<[WriteCvtF2F]>;<br>
+                       [], IIC_SSE_CVT_PD_RR>, VEX, Sched<[WriteCvtF2F]>;<br>
<br>
 // XMM only<br>
 def : InstAlias<"vcvtpd2psx\t{$src, $dst|$dst, $src}",<br>
                 (VCVTPD2PSrr VR128:$dst, VR128:$src), 0>;<br>
 def VCVTPD2PSXrm : VPDI<0x5A, MRMSrcMem, (outs VR128:$dst), (ins f128mem:$src),<br>
                         "cvtpd2psx\t{$src, $dst|$dst, $src}",<br>
-                        [(set VR128:$dst,<br>
-                          (int_x86_sse2_cvtpd2ps (loadv2f64 addr:$src)))],<br>
-                        IIC_SSE_CVT_PD_RM>, VEX, Sched<[WriteCvtF2FLd]>;<br>
+                        [], IIC_SSE_CVT_PD_RM>, VEX, Sched<[WriteCvtF2FLd]>;<br>
<br>
 // YMM only<br>
 def VCVTPD2PSYrr : VPDI<0x5A, MRMSrcReg, (outs VR128:$dst), (ins VR256:$src),<br>
@@ -2267,14 +2264,10 @@ def : InstAlias<"vcvtpd2ps\t{$src, $dst|<br>
<br>
 def CVTPD2PSrr : PDI<0x5A, MRMSrcReg, (outs VR128:$dst), (ins VR128:$src),<br>
                      "cvtpd2ps\t{$src, $dst|$dst, $src}",<br>
-                     [(set VR128:$dst, (int_x86_sse2_cvtpd2ps VR128:$src))],<br>
-                     IIC_SSE_CVT_PD_RR>, Sched<[WriteCvtF2F]>;<br>
+                     [], IIC_SSE_CVT_PD_RR>, Sched<[WriteCvtF2F]>;<br>
 def CVTPD2PSrm : PDI<0x5A, MRMSrcMem, (outs VR128:$dst), (ins f128mem:$src),<br>
                      "cvtpd2ps\t{$src, $dst|$dst, $src}",<br>
-                     [(set VR128:$dst,<br>
-                       (int_x86_sse2_cvtpd2ps (memopv2f64 addr:$src)))],<br>
-                     IIC_SSE_CVT_PD_RM>, Sched<[WriteCvtF2FLd]>;<br>
-<br>
+                     [], IIC_SSE_CVT_PD_RM>, Sched<[WriteCvtF2FLd]>;<br>
<br>
 // AVX 256-bit register conversion intrinsics<br>
 // FIXME: Migrate SSE conversion intrinsics matching to use patterns as below<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>