<div dir="ltr">I don't have any substantive comments on this point.<div>Not sure if anyone else does.</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 31, 2016 at 3:28 PM, Dehao Chen <span dir="ltr"><<a href="mailto:danielcdh@gmail.com" target="_blank">danielcdh@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks everyone for the reviews.<div><br></div><div>I've already integrated Duncan's change to this patch. Now we can do in-place replacement with reverse-iterator (Thanks Duncan).</div><div><br></div><div>Any other comments about this patch?</div><div><br></div><div>Thanks,</div><div>Dehao</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 31, 2016 at 9:41 AM, Dehao Chen <span dir="ltr"><<a href="mailto:danielcdh@gmail.com" target="_blank">danielcdh@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">danielcdh updated this revision to Diff 69869.<br>
danielcdh added a comment.<br>
<br>
Integrate with reverse-iterator enhancement.<br>
<span><br>
<br>
<a href="https://reviews.llvm.org/D22778" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2277<wbr>8</a><br>
<br>
Files:<br>
  include/llvm/InitializePasses.<wbr>h<br>
  include/llvm/LinkAllPasses.h<br>
  include/llvm/Transforms/Scalar<wbr>.h<br>
</span><div><div>  include/llvm/Transforms/Utils/<wbr>Local.h<br>
  include/llvm/Transforms/Utils/<wbr>LoopUtils.h<br>
  lib/Transforms/Scalar/CMakeLis<wbr>ts.txt<br>
  lib/Transforms/Scalar/GVN.cpp<br>
  lib/Transforms/Scalar/LICM.cpp<br>
  lib/Transforms/Scalar/LoopSink<wbr>.cpp<br>
  lib/Transforms/Scalar/Scalar.c<wbr>pp<br>
  lib/Transforms/Utils/Local.cpp<br>
  lib/Transforms/Utils/SimplifyI<wbr>nstructions.cpp<br>
  test/Transforms/LICM/loopsink.<wbr>ll<br>
  test/Transforms/LICM/sink.ll<br>
<br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>