<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thank you Teresa :)<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 31, 2016, at 9:24 AM, Teresa Johnson <<a href="mailto:tejohnson@google.com" class="">tejohnson@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Fixed test, un-XFAILed, moved to new X86 subdir in r280256</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Thanks, Teresa</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Mon, Aug 29, 2016 at 10:20 AM, Mehdi Amini <</span><a href="mailto:mehdi.amini@apple.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">mehdi.amini@apple.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">> wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class="">On Aug 29, 2016, at 10:14 AM, Teresa Johnson <<a href="mailto:tejohnson@google.com" class="">tejohnson@google.com</a>> wrote:<br class=""><br class="">On Mon, Aug 29, 2016 at 10:11 AM, Mehdi Amini <<a href="mailto:mehdi.amini@apple.com" class="">mehdi.amini@apple.com</a>> wrote:<br class=""><br class=""><br class="">On Aug 29, 2016, at 10:07 AM, Teresa Johnson <<a href="mailto:tejohnson@google.com" class="">tejohnson@google.com</a>> wrote:<br class=""><br class="">On Mon, Aug 29, 2016 at 9:57 AM, Mehdi Amini <<a href="mailto:mehdi.amini@apple.com" class="">mehdi.amini@apple.com</a>> wrote:<br class=""><br class=""><br class="">On Aug 29, 2016, at 6:14 AM, Teresa Johnson <<a href="mailto:tejohnson@google.com" class="">tejohnson@google.com</a>> wrote:<br class=""><br class="">Hi Mehdi,<br class=""><br class="">Is it necessary for this test to only run on X86? If so, we should<br class="">create an X86 subdirectory in test/tools/llvm-lto2 and test<br class="">config.root.targets in<br class="">the lit as done elsewhere for X86-specific tests.<br class=""><br class="">Looks like my recent common fix broke this test (but it was hidden<br class="">since it wasn't actually running). Will take a look at fixing that<br class="">part, but I'm not sure if it is safe to enable everywhere given the<br class="">original attempt to limit it.<br class=""><br class=""><br class="">The issue is that a triple/datalayout is needed for the mangling to be<br class="">correct during LTO (symbols are prefixed with _ on Darwin).<br class="">Not adding a triple/datalayout makes the tests behave differently depending<br class="">on the default triple llvm is built with (usually the host).<br class=""><br class="">Adding only a data layout and no triple may be enough for the mangling, but<br class="">the CodeGen will assert when the data layout does not match the<br class="">TargetMachine, so I’m not sure it’ll work.<br class=""><br class=""><br class="">Is it not enough to add both an x86 target triple and datalayout to the<br class="">test?<br class=""><br class=""><br class="">Which is what I did, but then you can only run when the X86 backend is<br class="">configured, which I tried (and failed) to achieve with the REQUIRES line.<br class=""><br class=""><br class="">Oh ok (there isn't a target datalayout there, which is why I asked).<br class=""><br class=""><br class="">I missed this, probably not intended.<br class=""><br class="">Also as I’m looking to the test, the resolutions don’t have the leading<br class="">underscore. I assume we don’t add the data layout when it’s missing.<br class="">It’d be easy to just turn the triple into a linux one and add the relevant<br class="">data layout.<br class=""><br class="">—<br class="">Mehdi<br class=""><br class=""><br class=""><br class=""><br class="">You suggested the right thing earlier (adding a X86 subdirectory as usual) I<br class="">think.<br class=""><br class=""><br class="">Ok, will do. I have the fixes ready to the non-xfailed version, so will do<br class="">both.<br class=""><br class="">Teresa<br class=""><br class=""><br class="">—<br class="">Mehdi<br class=""><br class=""><br class=""><br class="">Teresa<br class=""><br class=""><br class="">—<br class="">Mehdi<br class=""><br class=""><br class=""><br class="">Thanks,<br class="">Teresa<br class=""><br class="">On Mon, Aug 29, 2016 at 5:41 AM, Benjamin Kramer via llvm-commits<br class=""><<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""><br class="">Author: d0k<br class="">Date: Mon Aug 29 07:41:32 2016<br class="">New Revision: 279966<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=279966&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=279966&view=rev</a><br class="">Log:<br class="">Mark test as XFAIL instead of disabling it everywhere.<br class=""><br class="">There is no lit feature 'X86' so this test is just disabled completely.<br class="">Make it XFAIL until a solution is found.<br class=""><br class="">Modified:<br class="">llvm/trunk/test/tools/llvm-lto2/common.ll<br class=""><br class="">Modified: llvm/trunk/test/tools/llvm-lto2/common.ll<br class="">URL:<br class=""><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-lto2/common.ll?rev=279966&r1=279965&r2=279966&view=diff" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-lto2/common.ll?rev=279966&r1=279965&r2=279966&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/test/tools/llvm-lto2/common.ll (original)<br class="">+++ llvm/trunk/test/tools/llvm-lto2/common.ll Mon Aug 29 07:41:32 2016<br class="">@@ -1,4 +1,4 @@<br class="">-; REQUIRES: X86<br class="">+; XFAIL: *<br class="">; RUN: llvm-as < %s > %t1.bc<br class="">; RUN: llvm-as < %p/Inputs/common.ll > %t2.bc<br class=""><br class="">@@ -63,4 +63,4 @@ target triple = "x86_64-apple-macosx10.1<br class=""><br class="">define i8 *@foo() {<br class="">ret i8 *@v<br class="">-}<br class="">\ No newline at end of file<br class="">+}<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class="">llvm-commits@lists.llvm.org<br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""><br class=""><br class=""><br class=""><br class="">--<br class="">Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413<br class=""><br class=""><br class=""><br class=""><br class=""><br class="">--<br class="">Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413<br class=""><br class=""><br class=""><br class=""><br class=""><br class="">--<br class="">Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413<br class=""><br class=""><br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">--<span class="Apple-converted-space"> </span></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Teresa Johnson | Software Engineer |<span class="Apple-converted-space"> </span></span><a href="mailto:tejohnson@google.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">tejohnson@google.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class=""><span class="Apple-converted-space"> </span>| 408-460-2413</span></div></blockquote></div><br class=""></div></body></html>