<div dir="ltr">Should be fixed in <span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif;font-size:15.6px;line-height:23.4px">r279802. Please try again?</span></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 26, 2016 at 12:32 PM Dean Michael Berris <<a href="mailto:dberris@google.com">dberris@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes, sorry for the delay here -- let me have a crack at this today.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 26, 2016 at 6:19 AM Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I see this too when running "ninja check-all". <div>Any chance to fix it? </div><div><br></div><div>--kcc </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 10, 2016 at 10:08 AM, David Blaikie via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I seem to get a test failure when this is OFF (which it is on my build - I think the default is only applied when the variable is first seen, so everyone with it defaulting to OFF have it OFF now unless they blow away their CMakeCache):<br><br><div>FAIL: XRay-x86_64-linux :: TestCases/Linux/patching-unpatching.cc (30257 of 31128) ******************** TEST 'XRay-x86_64-linux :: TestCases/Linux/patching-unpatching.cc' FAILED ********************</div><div>Script:</div><div>--</div><div>/usr/local/google/home/blaikie/dev/llvm/build/clang/debug/split/notypes/nostandalone/./bin/clang --driver-mode=g++ -fxray-instrument -m64 -fxray-instrument -std=c++11 /mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc -o /mnt/fast/dev/llvm/build/clang/debug/split/notypes/nostandalone/projects/compiler-rt/test/xray/X86_64LinuxConfig/TestCases/Linux/Output/patching-unpatching.cc.tmp</div><div>XRAY_OPTIONS="patch_premain=false" /mnt/fast/dev/llvm/build/clang/debug/split/notypes/nostandalone/projects/compiler-rt/test/xray/X86_64LinuxConfig/TestCases/Linux/Output/patching-unpatching.cc.tmp 2>&1 | FileCheck /mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc</div><div>--</div><div>Exit Code: 1</div><div><br></div><div>Command Output (stderr):</div><div>--</div><div>/usr/local/google/home/blaikie/install/bin/ld: error: cannot open /mnt/fast/dev/llvm/build/clang/debug/split/notypes/nostandalone/bin/../lib/clang/4.0.0/lib/linux/libclang_rt.xray-x86_64.a: No such file or directory</div><div>/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function main: error: undefined reference to '__xray_set_handler'</div><div>/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function main: error: undefined reference to '__xray_patch'</div><div>/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function main: error: undefined reference to '__xray_unpatch'</div><div>/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function main: error: undefined reference to '__xray_patch'</div><div>/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function main: error: undefined reference to '__xray_remove_handler'</div><div>/tmp/patching-unpatching-e6b77d.o:/mnt/fast/dev/llvm/src/projects/compiler-rt/test/xray/TestCases/Linux/patching-unpatching.cc:function main: error: undefined reference to '__xray_unpatch'</div><div>clang-3.5: error: linker command failed with exit code 1 (use -v to see invocation)</div><div><br></div><div>--<br><br>Sounds like the test for xray isn't being disabled when the xray feature is disabled?</div></div><div class="m_8838344816948811019m_-5442427164337080291HOEnZb"><div class="m_8838344816948811019m_-5442427164337080291h5"><br><div class="gmail_quote"><div dir="ltr">On Sun, Aug 7, 2016 at 9:06 PM Dean Michael Berris via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dberris<br>
Date: Sun Aug 7 22:58:57 2016<br>
New Revision: 277975<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=277975&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=277975&view=rev</a><br>
Log:<br>
[compiler-rt][XRay] Default COMPILER_RT_BUILD_XRAY to ON<br>
<br>
Modified:<br>
compiler-rt/trunk/CMakeLists.txt<br>
<br>
Modified: compiler-rt/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=277975&r1=277974&r2=277975&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=277975&r1=277974&r2=277975&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/CMakeLists.txt (original)<br>
+++ compiler-rt/trunk/CMakeLists.txt Sun Aug 7 22:58:57 2016<br>
@@ -38,9 +38,7 @@ option(COMPILER_RT_BUILD_BUILTINS "Build<br>
mark_as_advanced(COMPILER_RT_BUILD_BUILTINS)<br>
option(COMPILER_RT_BUILD_SANITIZERS "Build sanitizers" ON)<br>
mark_as_advanced(COMPILER_RT_BUILD_SANITIZERS)<br>
-<br>
-# TODO: Flip this to default ON when build bots recognize this new option.<br>
-option(COMPILER_RT_BUILD_XRAY "Build xray" OFF)<br>
+option(COMPILER_RT_BUILD_XRAY "Build xray" ON)<br>
mark_as_advanced(COMPILER_RT_BUILD_XRAY)<br>
<br>
if (COMPILER_RT_STANDALONE_BUILD)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div></blockquote></div>