<div dir="ltr">I see this too when running "ninja check-all". <div>Any chance to fix it? </div><div><br></div><div>--kcc </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 10, 2016 at 10:08 AM, David Blaikie via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I seem to get a test failure when this is OFF (which it is on my build - I think the default is only applied when the variable is first seen, so everyone with it defaulting to OFF have it OFF now unless they blow away their CMakeCache):<br><br><div>FAIL: XRay-x86_64-linux :: TestCases/Linux/patching-<wbr>unpatching.cc (30257 of 31128)                                                        ******************** TEST 'XRay-x86_64-linux :: TestCases/Linux/patching-<wbr>unpatching.cc' FAILED ********************</div><div>Script:</div><div>--</div><div>/usr/local/google/home/<wbr>blaikie/dev/llvm/build/clang/<wbr>debug/split/notypes/<wbr>nostandalone/./bin/clang --driver-mode=g++ -fxray-instrument -m64  -fxray-instrument -std=c++11 /mnt/fast/dev/llvm/src/<wbr>projects/compiler-rt/test/<wbr>xray/TestCases/Linux/patching-<wbr>unpatching.cc -o /mnt/fast/dev/llvm/build/<wbr>clang/debug/split/notypes/<wbr>nostandalone/projects/<wbr>compiler-rt/test/xray/X86_<wbr>64LinuxConfig/TestCases/Linux/<wbr>Output/patching-unpatching.cc.<wbr>tmp</div><div>XRAY_OPTIONS="patch_premain=<wbr>false"  /mnt/fast/dev/llvm/build/<wbr>clang/debug/split/notypes/<wbr>nostandalone/projects/<wbr>compiler-rt/test/xray/X86_<wbr>64LinuxConfig/TestCases/Linux/<wbr>Output/patching-unpatching.cc.<wbr>tmp 2>&1 | FileCheck /mnt/fast/dev/llvm/src/<wbr>projects/compiler-rt/test/<wbr>xray/TestCases/Linux/patching-<wbr>unpatching.cc</div><div>--</div><div>Exit Code: 1</div><div><br></div><div>Command Output (stderr):</div><div>--</div><div>/usr/local/google/home/<wbr>blaikie/install/bin/ld: error: cannot open /mnt/fast/dev/llvm/build/<wbr>clang/debug/split/notypes/<wbr>nostandalone/bin/../lib/clang/<wbr>4.0.0/lib/linux/libclang_rt.<wbr>xray-x86_64.a: No such file or directory</div><div>/tmp/patching-unpatching-<wbr>e6b77d.o:/mnt/fast/dev/llvm/<wbr>src/projects/compiler-rt/test/<wbr>xray/TestCases/Linux/patching-<wbr>unpatching.cc:function main: error: undefined reference to '__xray_set_handler'</div><div>/tmp/patching-unpatching-<wbr>e6b77d.o:/mnt/fast/dev/llvm/<wbr>src/projects/compiler-rt/test/<wbr>xray/TestCases/Linux/patching-<wbr>unpatching.cc:function main: error: undefined reference to '__xray_patch'</div><div>/tmp/patching-unpatching-<wbr>e6b77d.o:/mnt/fast/dev/llvm/<wbr>src/projects/compiler-rt/test/<wbr>xray/TestCases/Linux/patching-<wbr>unpatching.cc:function main: error: undefined reference to '__xray_unpatch'</div><div>/tmp/patching-unpatching-<wbr>e6b77d.o:/mnt/fast/dev/llvm/<wbr>src/projects/compiler-rt/test/<wbr>xray/TestCases/Linux/patching-<wbr>unpatching.cc:function main: error: undefined reference to '__xray_patch'</div><div>/tmp/patching-unpatching-<wbr>e6b77d.o:/mnt/fast/dev/llvm/<wbr>src/projects/compiler-rt/test/<wbr>xray/TestCases/Linux/patching-<wbr>unpatching.cc:function main: error: undefined reference to '__xray_remove_handler'</div><div>/tmp/patching-unpatching-<wbr>e6b77d.o:/mnt/fast/dev/llvm/<wbr>src/projects/compiler-rt/test/<wbr>xray/TestCases/Linux/patching-<wbr>unpatching.cc:function main: error: undefined reference to '__xray_unpatch'</div><div>clang-3.5: error: linker command failed with exit code 1 (use -v to see invocation)</div><div><br></div><div>--<br><br>Sounds like the test for xray isn't being disabled when the xray feature is disabled?</div></div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Sun, Aug 7, 2016 at 9:06 PM Dean Michael Berris via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dberris<br>
Date: Sun Aug  7 22:58:57 2016<br>
New Revision: 277975<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=277975&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=277975&view=rev</a><br>
Log:<br>
[compiler-rt][XRay] Default COMPILER_RT_BUILD_XRAY to ON<br>
<br>
Modified:<br>
    compiler-rt/trunk/CMakeLists.<wbr>txt<br>
<br>
Modified: compiler-rt/trunk/CMakeLists.<wbr>txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=277975&r1=277974&r2=277975&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>CMakeLists.txt?rev=277975&r1=<wbr>277974&r2=277975&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/CMakeLists.<wbr>txt (original)<br>
+++ compiler-rt/trunk/CMakeLists.<wbr>txt Sun Aug  7 22:58:57 2016<br>
@@ -38,9 +38,7 @@ option(COMPILER_RT_BUILD_<wbr>BUILTINS "Build<br>
 mark_as_advanced(COMPILER_RT_<wbr>BUILD_BUILTINS)<br>
 option(COMPILER_RT_BUILD_<wbr>SANITIZERS "Build sanitizers" ON)<br>
 mark_as_advanced(COMPILER_RT_<wbr>BUILD_SANITIZERS)<br>
-<br>
-# TODO: Flip this to default ON when build bots recognize this new option.<br>
-option(COMPILER_RT_BUILD_XRAY "Build xray" OFF)<br>
+option(COMPILER_RT_BUILD_XRAY "Build xray" ON)<br>
 mark_as_advanced(COMPILER_RT_<wbr>BUILD_XRAY)<br>
<br>
 if (COMPILER_RT_STANDALONE_BUILD)<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</div></div><br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>