<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks!<div class=""><br class=""><div class=""><div><blockquote type="cite" class=""><div class="">On Aug 24, 2016, at 11:20 AM, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com" class="">rafael.espindola@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><p dir="ltr" class="">It should be checking the file format. I will fix that after lunch. Thanks.</p>
<div class="gmail_extra"><br class=""><div class="gmail_quote">On Aug 24, 2016 1:52 PM, "Steven Wu" <<a href="mailto:stevenwu@apple.com" class="">stevenwu@apple.com</a>> wrote:<br type="attribution" class=""><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Rafael<br class="">
<br class="">
I run into a problem for this commit. See comment below.<br class="">
<div class="elided-text"><br class="">
> On May 27, 2016, at 3:41 PM, Rafael Espindola via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> Author: rafael<br class="">
> Date: Fri May 27 17:41:51 2016<br class="">
> New Revision: 271066<br class="">
><br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=271066&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=271066&view=rev</a><br class="">
> Log:<br class="">
> Start using shouldAssumeDSOLocal on ARM.<br class="">
><br class="">
> Given where this is used it should be a nop.<br class="">
><br class="">
> Modified:<br class="">
> llvm/trunk/lib/Target/ARM/<wbr class="">ARMSubtarget.cpp<br class="">
><br class="">
> Modified: llvm/trunk/lib/Target/ARM/<wbr class="">ARMSubtarget.cpp<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMSubtarget.cpp?rev=271066&r1=271065&r2=271066&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/llvm/trunk/lib/Target/<wbr class="">ARM/ARMSubtarget.cpp?rev=<wbr class="">271066&r1=271065&r2=271066&<wbr class="">view=diff</a><br class="">
> ==============================<wbr class="">==============================<wbr class="">==================<br class="">
> --- llvm/trunk/lib/Target/ARM/<wbr class="">ARMSubtarget.cpp (original)<br class="">
> +++ llvm/trunk/lib/Target/ARM/<wbr class="">ARMSubtarget.cpp Fri May 27 17:41:51 2016<br class="">
> @@ -22,6 +22,7 @@<br class="">
> #include "Thumb1FrameLowering.h"<br class="">
> #include "Thumb1InstrInfo.h"<br class="">
> #include "Thumb2InstrInfo.h"<br class="">
> +#include "llvm/CodeGen/Analysis.h"<br class="">
> #include "llvm/CodeGen/<wbr class="">MachineRegisterInfo.h"<br class="">
> #include "llvm/IR/Attributes.h"<br class="">
> #include "llvm/IR/Function.h"<br class="">
> @@ -273,40 +274,19 @@ bool ARMSubtarget::isAAPCS16_ABI() const<br class="">
> return TM.TargetABI == ARMBaseTargetMachine::ARM_ABI_<wbr class="">AAPCS16;<br class="">
> }<br class="">
><br class="">
> -<br class="">
> -/// GVIsIndirectSymbol - true if the GV will be accessed via an indirect symbol.<br class="">
> +/// true if the GV will be accessed via an indirect symbol.<br class="">
> bool<br class="">
> ARMSubtarget::<wbr class="">GVIsIndirectSymbol(const GlobalValue *GV,<br class="">
> Reloc::Model RelocM) const {<br class="">
> - if (RelocM == Reloc::Static)<br class="">
> - return false;<br class="">
> -<br class="">
> - bool isDef = GV-><wbr class="">isStrongDefinitionForLinker();<br class="">
> + if (!shouldAssumeDSOLocal(RelocM, TargetTriple, *GV->getParent(), GV))<br class="">
> + return true;<br class="">
><br class="">
> - if (!isTargetMachO()) {<br class="">
> - // Extra load is needed for all externally visible.<br class="">
> - if (GV->hasLocalLinkage() || GV->hasHiddenVisibility())<br class="">
> - return false;<br class="">
> + // 32 bit macho has no relocation for a-b if a is undefined, even if b is in<br class="">
> + // the section that is being relocated. This means we have to use o load even<br class="">
> + // for GVs that are known to be local to the dso.<br class="">
> + if (isTargetDarwin() && RelocM == Reloc::PIC_ &&<br class="">
> + (GV->isDeclarationForLinker() || GV->hasCommonLinkage()))<br class="">
</div>Is there any specific reason using isTargetDarwin() instead of isTargetMachO()? This seems like a general limitation for MachO which is not specific to Darwin. When I compiling embedded architecture for MachO (armv7em), my target is not Darwin but it is still MachO (default triple is thumbv7em-apple-unknown-macho)<wbr class="">. I will get error like:<br class="">
fatal error: error in backend: symbol '*' can not be undefined in a subtraction expression<br class="">
<br class="">
Thanks<br class="">
<font color="#888888" class=""><br class="">
Steven<br class="">
</font><div class="elided-text"><br class="">
> return true;<br class="">
> - } else {<br class="">
> - // If this is a strong reference to a definition, it is definitely not<br class="">
> - // through a stub.<br class="">
> - if (isDef)<br class="">
> - return false;<br class="">
> -<br class="">
> - // Unless we have a symbol with hidden visibility, we have to go through a<br class="">
> - // normal $non_lazy_ptr stub because this symbol might be resolved late.<br class="">
> - if (!GV->hasHiddenVisibility()) // Non-hidden $non_lazy_ptr reference.<br class="">
> - return true;<br class="">
> -<br class="">
> - if (RelocM == Reloc::PIC_) {<br class="">
> - // If symbol visibility is hidden, we have a stub for common symbol<br class="">
> - // references and external declarations.<br class="">
> - if (GV->isDeclarationForLinker() || GV->hasCommonLinkage())<br class="">
> - // Hidden $non_lazy_ptr reference.<br class="">
> - return true;<br class="">
> - }<br class="">
> - }<br class="">
><br class="">
> return false;<br class="">
> }<br class="">
><br class="">
><br class="">
> ______________________________<wbr class="">_________________<br class="">
> llvm-commits mailing list<br class="">
> <a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
<br class="">
</div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></div></body></html>