<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Indeed: r279545<div class=""><br class=""></div><div class="">Thanks!</div><div class=""><br class=""></div><div class="">—</div><div class="">Mehdi</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 23, 2016, at 10:21 AM, Xinliang David Li <<a href="mailto:xinliangli@gmail.com" class="">xinliangli@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Is it possible to add some test?<div class=""><br class=""></div><div class="">David</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Aug 23, 2016 at 9:53 AM, Mehdi Amini via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mehdi_amini<br class="">
Date: Tue Aug 23 11:53:34 2016<br class="">
New Revision: 279532<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=279532&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=279532&view=rev</a><br class="">
Log:<br class="">
[ThinLTO] Make sure the Context used for the ThinLTO backend has all the appropriate options<br class="">
<br class="">
An important performance setting on the LLVMContext for LTO is<br class="">
enableDebugTypeODRUniquing(), this adds an automatic merging of<br class="">
debug information in the context based on type ids.<br class="">
<br class="">
Also, the lto::Config includes a diagnostic handler that needs to<br class="">
be set on the Context, as well as the setDiscardValueNames() setting.<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/LTO/LTO.cpp<br class="">
llvm/trunk/lib/LTO/LTOBackend.<wbr class="">cpp<br class="">
<br class="">
Modified: llvm/trunk/lib/LTO/LTO.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LTO.cpp?rev=279532&r1=279531&r2=279532&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/llvm/trunk/lib/LTO/<wbr class="">LTO.cpp?rev=279532&r1=279531&<wbr class="">r2=279532&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/lib/LTO/LTO.cpp (original)<br class="">
+++ llvm/trunk/lib/LTO/LTO.cpp Tue Aug 23 11:53:34 2016<br class="">
@@ -468,7 +468,7 @@ public:<br class="">
const FunctionImporter::ImportMapTy &ImportList,<br class="">
const GVSummaryMapTy &DefinedGlobals,<br class="">
MapVector<StringRef, MemoryBufferRef> &ModuleMap) {<br class="">
- LLVMContext BackendContext;<br class="">
+ LTOLLVMContext BackendContext(Conf);<br class="">
<br class="">
ErrorOr<std::unique_ptr<<wbr class="">Module>> MOrErr =<br class="">
parseBitcodeFile(MBRef, BackendContext);<br class="">
<br class="">
Modified: llvm/trunk/lib/LTO/LTOBackend.<wbr class="">cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LTOBackend.cpp?rev=279532&r1=279531&r2=279532&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/llvm/trunk/lib/LTO/<wbr class="">LTOBackend.cpp?rev=279532&r1=<wbr class="">279531&r2=279532&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/lib/LTO/LTOBackend.<wbr class="">cpp (original)<br class="">
+++ llvm/trunk/lib/LTO/LTOBackend.<wbr class="">cpp Tue Aug 23 11:53:34 2016<br class="">
@@ -271,6 +271,8 @@ Error lto::thinBackend(Config &Conf, uns<br class="">
return Error();<br class="">
<br class="">
auto ModuleLoader = [&](StringRef Identifier) {<br class="">
+ assert(Mod.getContext().<wbr class="">isODRUniquingDebugTypes() &&<br class="">
+ "ODR Type uniquing shoudl be enabled on the context");<br class="">
return std::move(<wbr class="">getLazyBitcodeModule(<wbr class="">MemoryBuffer::getMemBuffer(<br class="">
ModuleMap[Identifier], false),<br class="">
Mod.getContext(),<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>