<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 8/22/2016 11:28 AM, Daniel Berlin
via llvm-commits wrote:<br>
</div>
<blockquote
cite="mid:CAF4BwTXG+XhKPLC1BuphWgbTLorKw2X40f-AEqskjF=VKec8RA@mail.gmail.com"
type="cite">
<div dir="ltr">+philip because he expressed concerns around
limiting
<div><br>
</div>
<div>+eli
<div><br>
</div>
<div>Eli, i think your patch to DSE to do exact may-throw
tracking is what made this worse.</div>
<div><br>
</div>
</div>
<div><a moz-do-not-send="true"
href="https://llvm.org/bugs/show_bug.cgi?id=29064">https://llvm.org/bugs/show_bug.cgi?id=29064</a><br>
</div>
</div>
</blockquote>
<br>
I don't think it's the fault of my recent patch. The stack trace
from that bug points into MemDep, not my new code, and the patch
which fixes it doesn't touch my new code.<br>
<br>
<blockquote
cite="mid:CAF4BwTXG+XhKPLC1BuphWgbTLorKw2X40f-AEqskjF=VKec8RA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>I'm not sure we should limit DSE.</div>
</div>
</blockquote>
<br>
An arbitrary limit isn't exactly ideal, but there probably isn't any
better way to fix the issue given the current algorithm used by DSE
and MemDep.<br>
<br>
-Eli<br>
<br>
<blockquote
cite="mid:CAF4BwTXG+XhKPLC1BuphWgbTLorKw2X40f-AEqskjF=VKec8RA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div><br>
I have an analysis pass just about ready to do the
EBB/maythrow stuff, which gives "some" may-throw tracking,
just not as exact as is being done here.</div>
<div>Rather than limit DSE, i think we should revert the
more-exact tracking for now unless we can show it produces
significant perf improvements.</div>
<div><br>
</div>
<div>Thoughts?</div>
<div><br>
</div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Aug 22, 2016 at 10:59 AM, David
Li <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:davidxl@google.com" target="_blank">davidxl@google.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">davidxl
added a comment.<br>
<br>
The patch fixes the issue in <a moz-do-not-send="true"
href="https://llvm.org/bugs/show_bug.cgi?id=29064"
rel="noreferrer" target="_blank">https://llvm.org/bugs/show_<wbr>bug.cgi?id=29064</a><br>
<br>
<br>
<a moz-do-not-send="true"
href="https://reviews.llvm.org/D15537" rel="noreferrer"
target="_blank">https://reviews.llvm.org/<wbr>D15537</a><br>
<br>
<br>
<br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
<p><br>
</p>
<pre class="moz-signature" cols="72">--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project</pre>
</body>
</html>