<div dir="ltr">Looks like Simon Pilgrim fixed this in r279426.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 22, 2016 at 12:53 AM, Yung, Douglas via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Mehdi,<br>
<br>
I'm not sure why, but the change you made seems to have caused the PS4 Windows bot to be red. From the latest test results (<a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/10356/steps/test/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/llvm-clang-lld-x86_<wbr>64-scei-ps4-windows10pro-fast/<wbr>builds/10356/steps/test/logs/<wbr>stdio</a>), it seems to have a problem with the "rm" command that you added:<br>
<br>
$ "rm" "-f" "C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.obj\<wbr>test\ThinLTO\X86\Output\emit_<wbr>imports.ll.tmp*.thinlto.bc" "C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.obj\<wbr>test\ThinLTO\X86\Output\emit_<wbr>imports.ll.tmp*.bc.imports"<br>
# command stderr:<br>
rm: cannot remove `C:\\Buildbot\\Slave\\llvm-<wbr>clang-lld-x86_64-scei-ps4-<wbr>windows10pro-fast\\llvm.obj\\<wbr>test\\ThinLTO\\X86\\Output\\<wbr>emit_imports.ll.tmp*.thinlto.<wbr>bc': Invalid argument<br>
<br>
Can you take a look into this?<br>
<br>
Douglas Yung<br>
<div><div class="h5"><br>
> -----Original Message-----<br>
> From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org">llvm-commits-bounces@<wbr>lists.llvm.org</a>] On<br>
> Behalf Of Mehdi Amini via llvm-commits<br>
> Sent: Friday, August 19, 2016 16:55<br>
> To: <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> Subject: [llvm] r279349 - [LTO] Add the ability to test -thinlto-emit-<br>
> imports-files through llvm-lto2<br>
><br>
> Author: mehdi_amini<br>
> Date: Fri Aug 19 18:54:40 2016<br>
> New Revision: 279349<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=279349&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=279349&view=rev</a><br>
> Log:<br>
> [LTO] Add the ability to test -thinlto-emit-imports-files through llvm-<br>
> lto2<br>
><br>
> Summary:<br>
> Start bringing llvm-lto2 to a level where we can test the LTO API a bit<br>
> deeper.<br>
><br>
> Reviewers: tejohnson<br>
><br>
> Subscribers: llvm-commits, mehdi_amini<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D23681" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D23681</a><br>
><br>
> Modified:<br>
>     llvm/trunk/test/ThinLTO/X86/<wbr>emit_imports.ll<br>
>     llvm/trunk/tools/llvm-lto2/<wbr>llvm-lto2.cpp<br>
><br>
> Modified: llvm/trunk/test/ThinLTO/X86/<wbr>emit_imports.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/llvm/trunk/test/<wbr>ThinLTO/X86/emit_imports.ll?<wbr>rev=279349&r1=27934<br>
> 8&r2=279349&view=diff<br>
> ==============================<wbr>==============================<wbr>===========<br>
> =======<br>
> --- llvm/trunk/test/ThinLTO/X86/<wbr>emit_imports.ll (original)<br>
> +++ llvm/trunk/test/ThinLTO/X86/<wbr>emit_imports.ll Fri Aug 19 18:54:40<br>
> 2016<br>
> @@ -12,6 +12,19 @@<br>
>  ; The imports file for Input/emit_imports.ll is empty as it does not<br>
> import anything.<br>
>  ; RUN: cat %t2.bc.imports | count 0<br>
><br>
</div></div>> +; RUN: rm -f %t*.thinlto.bc %t*.bc.imports ; RUN: llvm-lto2 %t1.bc<br>
> +%t2.bc -o %t.o \<br>
<div><div class="h5">> +; RUN:     -thinlto-distributed-indexes \<br>
> +; RUN:     -r=%t1.bc,g, \<br>
> +; RUN:     -r=%t1.bc,f,px \<br>
> +; RUN:     -r=%t2.bc,g,px<br>
> +<br>
> +; RUN: cat %t1.bc.imports | count 1<br>
> +; RUN: cat %t1.bc.imports | FileCheck %s --check-prefix=IMPORTS1<br>
> +<br>
> +; The imports file for Input/emit_imports.ll is empty as it does not<br>
> import anything.<br>
> +; RUN: cat %t2.bc.imports | count 0<br>
> +<br>
>  declare void @g(...)<br>
><br>
>  define void @f() {<br>
><br>
> Modified: llvm/trunk/tools/llvm-lto2/<wbr>llvm-lto2.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/llvm-</a><br>
> lto2/llvm-lto2.cpp?rev=279349&<wbr>r1=279348&r2=279349&view=diff<br>
> ==============================<wbr>==============================<wbr>===========<br>
> =======<br>
> --- llvm/trunk/tools/llvm-lto2/<wbr>llvm-lto2.cpp (original)<br>
> +++ llvm/trunk/tools/llvm-lto2/<wbr>llvm-lto2.cpp Fri Aug 19 18:54:40 2016<br>
> @@ -33,6 +33,15 @@ static cl::opt<std::string> OutputFilena<br>
><br>
>  static cl::opt<bool> SaveTemps("save-temps", cl::desc("Save temporary<br>
> files"));<br>
><br>
> +static cl::opt<bool><br>
> +    ThinLTODistributedIndexes("<wbr>thinlto-distributed-indexes",<br>
> cl::init(false),<br>
> +                              cl::desc("Write out individual index and<br>
> "<br>
> +                                       "import files for the "<br>
> +                                       "distributed backend case"));<br>
> +<br>
> +static cl::opt<int> Threads("-thinlto-threads",<br>
> +                            cl::init(thread::hardware_<wbr>concurrency()));<br>
> +<br>
>  static cl::list<std::string> SymbolResolutions(<br>
>      "r",<br>
>      cl::desc("Specify a symbol resolution:<br>
> filename,symbolname,<wbr>resolution\n"<br>
> @@ -135,7 +144,12 @@ int main(int argc, char **argv) {<br>
>      check(Conf.addSaveTemps(<wbr>OutputFilename + "."),<br>
>            "Config::addSaveTemps failed");<br>
><br>
> -  LTO Lto(std::move(Conf));<br>
> +  ThinBackend Backend;<br>
> +  if (ThinLTODistributedIndexes)<br>
</div></div>> +    Backend = createWriteIndexesThinBackend(<wbr>"", "", true, "");  else<br>
<div class="HOEnZb"><div class="h5">> +    Backend = createInProcessThinBackend(<wbr>Threads);<br>
> +  LTO Lto(std::move(Conf), std::move(Backend));<br>
><br>
>    bool HasErrors = false;<br>
>    for (std::string F : InputFilenames) {<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div>